! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Vertical panel length 100% relatively (be aware of other horizontal panel)
Status:
RESOLVED: DUPLICATE
Severity:
enhancement
Product:
Xfce4-panel

Comments

Description Luke 2012-05-14 21:53:48 CEST
Created attachment 4417 
Screenshot

Hi, basically try to reproduce ubuntu-shell-like-panels i.e. main horizontal panel on the top (width 100% of screen, absolute value) and second vertical on the side (100% of what's left, relative value). Right now I can set length of the panel only by absolute value so it will either overlap other panel or it will show gap between.

Regards.
Comment 1 Andrzej editbugs 2012-05-24 10:00:17 CEST
I think this is a duplicate of bug #8627.

I've posted a patch fixing this issue. I'd appreciate if you could please try it out and let me know if you find any problems with it.
Comment 2 Luke 2012-05-27 20:49:18 CEST
Ok... I've got little difficulties applying this patch, can you provide me some how-to?
Comment 3 Andrzej editbugs 2012-05-28 10:27:34 CEST
$ git clone git://git.xfce.org/xfce/xfce4-panel
$ cd xfce4-panel
(save the patch in this directory as "struts.patch")
$ git am struts.patch
$ ./autogen.sh --enable-maintainer-mode
$ make
$ sudo make install

If you have further questions send me an email.
Comment 4 Luke 2012-05-30 13:20:49 CEST
With patch everything seems to be working as it should :)

No wait... same issue if you want to swap vertical with horizontal panel. You can't set vertical panel to 100% of display absolute value and horizontal panel to 100% of whats left (maybe this is not a big problem but still looks awful If you can't do this). Unity-like panels works ok though.
Comment 5 Andrzej editbugs 2012-05-31 04:44:14 CEST
(In reply to comment #4)
> You can't set vertical panel to 100% of display absolute value and
> horizontal panel to 100% of whats left

That's by design.

If you look at the comment #1 of bug #8627, you'll see I initially planned to implement a more generic solution. The problem is that the logic of laying out the panels is getting quite complex (for example, the algorithm must work well with multiple partial panels on the screen). It is also not very obvious which panel should take precedence over others. An original idea was to use the panel number for setting the order, which is OK, except that once you create the panel, you can't change its number.

The patch always gives priority to horizontal panels, which achieves the goal (fixes panel overlap) and provides functionality equivalent to other DEs. Going further is simply not worths the effort (at least to me).

BTW, please post your replies under bug #8627 - this will make them more visible. Note that the patch is still not applied - I'm not the one to decide about it.
Comment 6 Simon Steinbeiss editbugs 2020-05-27 10:54:29 CEST

*** This bug has been marked as a duplicate of bug 8627 ***

Bug #8885

Reported by:
Luke
Reported on: 2012-05-14
Last modified on: 2020-05-27

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Version:
4.10.0

Attachments

Screenshot (43.25 KB, image/png)
2012-05-14 21:53 CEST , Luke
no flags

Additional information