! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
lost ftp bookmark after logout-login
Status:
RESOLVED: DUPLICATE

Comments

Description denis.prost 2012-05-13 21:27:40 CEST
1) open some non anonymous ftp location in thunar => location content properly displayed after entering user/password
2) create a bookmark for that location by dragging the icon at the beginning of the location field to the shortcuts panel => bookmark created
3) test that bookmark by clicking on it => it works fine
4) logout from XFCE, then login again and open thunar => no more FTP bookmark in the shortcuts list
Comment 1 Tomasz Wisniewski 2012-06-29 11:32:35 CEST
Created attachment 4532 
shortcuts check if path is uri

The problem that the shortcuts model does not check if the file from gtk-bookmarks is a valid uri. I have provided a small patch applicable for 1.3.0 and 1.4.0.
Comment 2 denis.prost 2012-06-29 22:49:30 CEST
Thanks Tomasz.
Unfortunately, I can't test it now (not feeling very easy with patching), but I'll test it as soon as next Thunar version is released.
Comment 3 Tomasz Wisniewski 2012-07-04 09:29:41 CEST
(In reply to comment #2)
> Thanks Tomasz.
> Unfortunately, I can't test it now (not feeling very easy with patching),
> but I'll test it as soon as next Thunar version is released.

Hello Denis

I can deliver You a patched binary if You wish. Please tell me which distro are You using - if You are interested of course.
Comment 4 denis.prost 2012-07-04 09:32:53 CEST
Thanks Tomasz for your kind proposal.
My distro is Ubuntu 12.04.
Comment 5 Tomasz Wisniewski 2012-07-06 10:12:27 CEST
Hello Denis

I prepared a patched sources for You - don't want to get accused of possible malware spreading, that is why it will be the best if You will compile them yourself. ./configure; make; . You can even launch it inside the build directory without a need to install and replace your original system thunar. The patch is applied to version 1.2.6 which I found should be the one currently installed in your distribution.
Comment 6 Tomasz Wisniewski 2012-07-06 10:47:57 CEST
Created attachment 4542 
patched sources

Unfortunately I was unable to post an original package (probably its too big). Attached is a patched file (thunar-shortcuts-model.c), it must be replaced manually in the original package which can be obtained from packages.ubuntu.com (http://archive.ubuntu.com/ubuntu/pool/universe/t/thunar/thunar_1.2.3.orig.tar.bz2). Sorry for inconvenience,
Comment 7 denis.prost 2012-07-06 11:01:55 CEST
Thanks Tomasz !
With all your explanations, I should succeed installing the new release.
I will do it as soon as possible and let you know if it solves my problem.
Regards,

Denis
Comment 8 denis.prost 2012-07-06 18:05:42 CEST
Just tested it, it works, thanks !
Comment 9 Nick Schermer editbugs 2012-09-30 08:56:13 CEST

*** This bug has been marked as a duplicate of bug 7645 ***

Bug #8879

Reported by:
denis.prost
Reported on: 2012-05-13
Last modified on: 2012-09-30

People

Assignee:
Jannis Pohlmann
CC List:
3 users

Version

Attachments

shortcuts check if path is uri (1.93 KB, patch)
2012-06-29 11:32 CEST , Tomasz Wisniewski
tomasz.wisni3wski : review+
patched sources (56.42 KB, text/plain)
2012-07-06 10:47 CEST , Tomasz Wisniewski
no flags

Additional information