! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] xfce4-sensors-1.2.3: Use new GTK tooltip API
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-sensors-plugin
Component:
General

Comments

Description Harald Judt 2012-05-08 18:47:12 CEST
Created attachment 4410 
use-new-tooltip-api.patch

Remove legacy code, do some cleanup and update the code to use GtkTooltip, using less lines than the current version.
Comment 1 Fabian Nowak editbugs 2012-05-08 20:04:06 CEST
thanks for the patch, looks good, but can you please indicate which gtk tooltip API one needs for that code? The plugin is supposed to also run with Xfce 4.4 and old GTK Versions, so I will still require the old code, I guess. From this point of view, your code might amke sense in two years when 95% of the Xfce systems are based on GTK versions with this tooltip API?
Comment 2 Harald Judt 2012-05-08 21:08:29 CEST
I'll rewrite it without removing that old code.

I thought we have reached those 95% already, but never mind. There are bugs that are much older than 2 years ;-)
Comment 3 Fabian Nowak editbugs 2012-05-08 22:28:13 CEST
Sorry, that wasn't my intention. First, I'd simply like to know when this tooltip API became available, which version it is.

Save your time for other reports, I have 2 years of bug reports to clean ;)
Comment 4 Fabian Nowak editbugs 2012-05-13 17:19:50 CEST
this api exists since 2.12: http://developer.gnome.org/gtk/2.24/GtkWidget.html#gtk-widget-set-tooltip-text 
2.12 was release 5 years ago: http://mail.gnome.org/archives/gtk-devel-list/2007-September/msg00052.html

So I simply applied your patch; thanks.

Bug #8854

Reported by:
Harald Judt
Reported on: 2012-05-08
Last modified on: 2012-05-13

People

Assignee:
Fabian Nowak
CC List:
0 users

Version

Version:
unspecified

Attachments

use-new-tooltip-api.patch (3.65 KB, patch)
2012-05-08 18:47 CEST , Harald Judt
no flags

Additional information