! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Can't build under FreeBSD
Status:
RESOLVED: FIXED
Product:
Xfce4-wavelan-plugin
Component:
General

Comments

Description Olivier Duchateau 2012-05-05 18:09:24 CEST
Created attachment 4398 
Build log of xfce4-wavelan-plugin 0.5.10

I try to build the latest version, under FreeBSD (8.2, i386), but it failed.

In attachment, build log (if it can help you).
Comment 1 Landry Breuil editbugs 2012-05-25 11:22:41 CEST
Comment on attachment 4398 
Build log of xfce4-wavelan-plugin 0.5.10

Can you track down which version broke it ? (ie which is the last one known working ?) Can you retry with commit c9616d3a from bug #6963 reverted ?

And lastly, can you provide a fix ? :)
Comment 2 Olivier Duchateau 2014-02-01 11:29:54 CET
Created attachment 5343 
Remove FreeBSD obsolete code
Comment 3 Olivier Duchateau 2014-02-01 11:30:46 CET
I found workaround (perhaps FreeBSD's specific code needs to be cleaned), if I remove obsolete code, everything works fine (tested with FreeBSD 9.2 and 10).

In fact struct wi_req is not any more defined (below excerpt of if_wavelan_ieee.h header file).

[...]
#if 0
struct wi_req {
        u_int16_t       wi_len;
        u_int16_t       wi_type;
        u_int16_t       wi_val[WI_MAX_DATALEN];
};
#endif

[...]

http://svnweb.freebsd.org/base/releng/9.2/sys/dev/wi/if_wavelan_ieee.h?view=markup
Comment 4 Skunnyk editbugs 2017-11-03 23:45:27 CET
Hi Olivier, 

wavelan master build is borken on freebsd since age (I'm looking at broken components on buildbot.xfce.org ) 

I see that FreeBSD has patches to build wavelan on https://svnweb.freebsd.org/ports/head/sysutils/xfce4-wavelan-plugin/files/ , any reason to not merge them upstream ? If it's ok, I'll merge them soon.
Comment 5 Git Bot editbugs 2017-11-16 13:40:20 CET
Romain B referenced this bugreport in commit 3bee79de2e70ffd8b07ed2190c0ccabe7f56e7a7

Fix build under and usage under FreeBSD

https://git.xfce.org/panel-plugins/xfce4-wavelan-plugin/commit?id=3bee79de2e70ffd8b07ed2190c0ccabe7f56e7a7
Comment 6 Olivier Duchateau 2017-11-16 17:59:05 CET
(In reply to Git Bot from comment #5)
> Romain B referenced this bugreport in commit
> 3bee79de2e70ffd8b07ed2190c0ccabe7f56e7a7
> 
> Fix build under and usage under FreeBSD
> 
> https://git.xfce.org/panel-plugins/xfce4-wavelan-plugin/
> commit?id=3bee79de2e70ffd8b07ed2190c0ccabe7f56e7a7

Your commit message is wrong, the predecessor  __FreeBSD_kernel__ is for Debian GNU/kFreeBSD, and it is not for FreeBSD system. We can build this plugin without this plague (in the past, it was required by corsac@).
Comment 7 Skunnyk editbugs 2017-11-17 17:34:09 CET
Hm, I simply applied the patch provided by FreeBSD which clean up the source a little bit, and allow compilation on freebsd. I haven't tested in the GNU/kFreeBSD context.

Bug #8833

Reported by:
Olivier Duchateau
Reported on: 2012-05-05
Last modified on: 2019-03-13

People

Assignee:
Skunnyk
CC List:
1 user

Version

Version:
0.5.5 or older

Attachments

Build log of xfce4-wavelan-plugin 0.5.10 (17.02 KB, text/plain)
2012-05-05 18:09 CEST , Olivier Duchateau
no flags
Remove FreeBSD obsolete code (4.17 KB, patch)
2014-02-01 11:29 CET , Olivier Duchateau
no flags

Additional information