! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Top border of maximized windows doesn't look right
Status:
RESOLVED: MOVED
Severity:
enhancement

Comments

Description Alex AUVOLAT 2012-04-29 23:31:02 CEST
Created attachment 4372 
What the windows should look like

When using the Redmond Xfwm theme, the top border of maximized windows is the same as normal, but that doesn't look right : the top 4 pixels, which are gray, should be hidden (see attachment).

The way Xfwm themes are build right now, the same top border for windows is used when the window is maximized and when it's not. I don't think it's necessary to have completely different borders for the two states, but maybee we could just have a new property in the themerc file that says that the top n pixels of the border must be hidden when the window is maximized.

I know this might look like a trivial matter, but I find that it makes the Redmond theme look ugly (and unrealistic!), and I guess other themes may also have that problem.

Steps to reproduce:
1. Select the Redmond Xfwm theme
2. Maximize a window

Thank you for your hard work, Xfce is great!
Comment 1 Alex AUVOLAT 2012-04-29 23:46:12 CEST
Oh, and it would seem that a property allowing the hiding of part of the top border when maximized would also allow hiding all the top border, which has been asked for in bug #3786.

Actually, this feature seems to have been requested also in bug #7436, sorry for the duplicate.

Anyway, I'll look into implementing my suggestion soon.
Comment 2 Alex AUVOLAT 2012-04-30 10:49:42 CEST
Created attachment 4374 
[PATCH] Added top_border_size property in themerc file.

If the top_border_size property is specified to N in the themerc file, the top N pixels of the top border will be hidden when the window is maximized and borderless maximize is enabled.
Comment 3 Git Bot editbugs 2020-05-29 11:49:11 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/74.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #8796

Reported by:
Alex AUVOLAT
Reported on: 2012-04-29
Last modified on: 2020-05-29

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Attachments

What the windows should look like (11.89 KB, image/png)
2012-04-29 23:31 CEST , Alex AUVOLAT
no flags
[PATCH] Added top_border_size property in themerc file. (7.05 KB, patch)
2012-04-30 10:49 CEST , Alex AUVOLAT
alexis211 : review+

Additional information