Pressing "Cancel" in password prompt dialog, while connecting to windows share, shows additional dialog with message that password was canceled. its stupid and annoying. Expected result: just silently close password prompt dialog
Created attachment 6714 Do not display error dialog for already handled errors Docs for G_IO_ERROR_FAILED_HANDLED (int: 30) at [1] document it as: Operation failed and a helper program has already interacted with the user. Do not display any error dialog. I've attached a patch to the error dialog function to do nothing for this "error". [1] https://www.freedesktop.org/software/gstreamer-sdk/data/docs/latest/gio/gio-GIOError.html#GIOErrorEnum
Makes sense to me, harald what do you think about this one ?
I have not tested it, but it makes sense.
@arbe: have you tested it in the 'canceling connection to windows share' case ?
I havent figured out the proper steps to reproduce the bug here..
@Landry: I have - I simply went to "Browse Network" > WORKGROUP > My router's samba share and when the dialog popped up I simply opted "Cancel". No further dialog was shown (as expected).
Okay, been able to test it the same way here, and indeed your patch removes the extraneous/annoying error dialog. I'll push it tonight!
Thanks armin, applied in http://git.xfce.org/xfce/thunar/commit/?id=febb41736615d76d73bf8156290296e3de49349b