! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
g_value_set_char()/g_value_get_char() is deprecated since glib 2.32 and break...
Status:
RESOLVED: FIXED

Comments

Description Landry Breuil editbugs 2012-04-13 16:41:46 CEST
+++ This bug was initially created as a clone of Bug #8689 +++


See bottom of http://buildbot.xfce.org/builders/xfconf-openbsd/builds/348/steps/gmake%20distcheck/logs/stdio

According to http://developer.gnome.org/gobject/unstable/gobject-Standard-Parameter-and-Value-Types.html#g-value-set-char g_value_set_char() is deprecated since glib 2.32 and g_value_set_schar() should be used instead. Same for g_value_get_char(). I know Xfce 4.10 requires glib 2.24 so the error wont occur there, but reporting anyway as minor bug.

occurences :
./xfconf/build/xfconf/xfconf-channel.c:                               g_value_set_char);
./xfconf/build/common/xfconf-gvaluefuncs.c:            HANDLE_INT(XFCONF_MINCHAR, XFCONF_MAXCHAR, g_value_set_char);
./xfconf/build/xfconf/xfconf-channel.c:                               g_value_get_char);
./xfconf/build/common/xfconf-gvaluefuncs.c:            return g_strdup_printf("%d", (gint)g_value_get_char(val));

Interestingly in various places g_value_get_char is override by an unused macro:

./thunar-vfs/build/thunar-vfs/thunar-vfs-private.h:#define g_value_get_char(v)     (((const GValue *) (v))->data[0].v_int)
./exo/build/exo/exo-private.h:#define g_value_get_char(v)     (((const GValue *) (v))->data[0].v_int)
./thunar/build/thunar/thunar-private.h:#define g_value_get_char(v)     (((const GValue *) (v))->data[0].v_int)
Comment 1 Nick Schermer editbugs 2012-04-13 17:52:20 CEST
Fixed in 93e8623.
Comment 2 Landry Breuil editbugs 2012-04-14 12:16:54 CEST
There's still an occurence of g_value_get_char() in the (insane) macro at http://git.xfce.org/xfce/xfconf/tree/common/xfconf-gvaluefuncs.c#n329

See http://buildbot.xfce.org/builders/xfconf-openbsd/builds/352/steps/gmake%20distcheck/logs/stdio
Comment 3 Nick Schermer editbugs 2012-04-18 19:14:11 CEST
Fixed some more in ce318f0.
Comment 4 Nick Schermer editbugs 2012-04-18 21:38:00 CEST
Fixed, but now the abicheck.sh fails. Sigh.
Comment 5 Landry Breuil editbugs 2012-04-18 22:22:51 CEST
Created attachment 4344 
backport bug #8702

xfconf's abicheck needs the same treatment as libxfce4ui's. With the attached patch gmake distcheck passes abicheck.sh fine

Bug #8690

Reported by:
Landry Breuil
Reported on: 2012-04-13
Last modified on: 2012-04-18

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
1 user

Version

Version:
Unspecified

Attachments

backport bug #8702 (901 bytes, patch)
2012-04-18 22:22 CEST , Landry Breuil
landry : review? ( nick )

Additional information