! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
configure should check for gnu sed
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Landry Breuil editbugs 2012-04-13 16:06:47 CEST
+++ This bug was initially created as a clone of Bug #8686 +++

sed -i is a gnu extension and is not present in OpenBSD's sed.

xfdesktop hardcodes its use in src/Makefile.am:

src/Makefile.am:              && sed -i -e 's/org_xfce_FileManager/xfdesktop_file_manager_proxy/g' \
src/Makefile.am:              && sed -i -e 's/org_xfce_Thunar/xfdesktop_thunar_proxy/g' \
src/Makefile.am:              && sed -i -e 's/org_xfce_Trash/xfdesktop_trash_proxy/g' \

configure should check for SED program (so that we can override it with SED=/usr/local/bin/gsed on OpenBSD) and use $(SED) in Makefile.am instead.

A way to check for it is :

dnl AC_PROG_SED is only avaliable in recent autoconf versions.
dnl Use AC_CHECK_PROG instead if AC_PROG_SED is not present.
ifdef([AC_PROG_SED],
      [AC_PROG_SED],
      [AC_CHECK_PROG(SED, sed, sed)])

(taken from http://svn.apache.org/repos/asf/apr/apr/trunk/configure.in)

AC_PROG_SED macro is available since autoconf 2.62.
Comment 1 Landry Breuil editbugs 2012-04-13 16:08:14 CEST
(Or configure could check for sed -i, and fallback to gsed :)
Comment 2 Nick Schermer editbugs 2012-04-13 18:01:03 CEST
Fixed in 7e81439.

Bug #8687

Reported by:
Landry Breuil
Reported on: 2012-04-13
Last modified on: 2012-04-13

People

Assignee:
Eric Koegel
CC List:
2 users

Version

Version:
Unspecified

Attachments

Additional information