Comment 1 Nick Schermer 2012-04-13 18:41:54 CEST

What happens if you use

g_timeout_add (250, _generate_menu_idled, desktop_menu);

(In reply to comment #1)
> What happens if you use
> 
> g_timeout_add (250, _generate_menu_idled, desktop_menu);

It's better, CPU rises only to 12% (on overage).

Comment 3 Nick Schermer 2012-04-13 23:18:07 CEST

Created attachment 4318 
Don't recreate menu, but only reload it

Looks like the code could recurse, could you try this patch? And if it doesn't work post the dbg output.

Comment 4 Nick Schermer 2012-04-15 09:52:22 CEST

Any news about this? I landed the attached patch in pre2, because it is better anyway.

With xfdesktop-4.9.3 CPU is still to 100%. I tested without this:

g_timeout_add (250, _generate_menu_idled, desktop_menu);

But I can.

Full log of when session starts (debug is enabled), http://avignu.tuxfamily.org/FreeBSD/xsession-errors

Comment 6 Nick Schermer 2012-04-15 13:27:23 CEST

Please attach the log, access denied.

Created attachment 4324 
log of xfdesktop

Comment 8 Nick Schermer 2012-04-15 16:20:15 CEST

Mm not's not going to help much. I've pushed a patch to garcon master to print debugging about file reloading, that will give some more into what is going on here.
You could give it a shot and attach the output?

Created attachment 4325 
Output of garcon and xfdesktop

Comment 10 Nick Schermer 2012-04-15 20:45:03 CEST

Mm interestingly, it looks like garcon receives G_FILE_MONITOR_EVENT_DELETED evens from the files ~/.config/menus/xfce-applications.menu and ~/.local/share/xfce-*.directory.

You don't have those files I think?

Comment 11 Nick Schermer 2012-04-15 21:01:04 CEST

Created attachment 4326 
Ignore delete events if the file causing the event is not used

I think we can work around this problem. Can you try the attached patch?

Created attachment 4327 
Output with new patch, load CPU is better around 8%

Comment 13 Nick Schermer 2012-04-15 23:56:00 CEST

Created attachment 4328 
Ignore delete events if the file causing the event is not used, v2

A better patch that is null safe, but I think there is not much we can improve here. at least xfdesktop is not racing anymore, neither is garcon, but possibly the gio file monitor.

Created attachment 4332 
Log with patch v2, when garcon and xfdesktop are 'debug' support enable, load CPU is around 5%

Comment 15 Nick Schermer 2012-04-17 21:45:27 CEST

Pushed a slightly modified version of the patch.

No I wonder, was the workaround a way to reduce the cpu usage or did it completely disappear? Because that would be strange..

Comment 16 Nick Schermer 2014-07-29 08:28:42 CEST

Old bug