! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
(xfdesktop) icon labels misaligned with thumbnails on.
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Andrzej editbugs 2012-04-07 17:43:02 CEST
When I turn thumbnails on, some of the icon labels are positioned higher than others. This happens for icons/thumbnails, which aspect ratio is larger than 1 (width>height).

The issue makes the desktop look rather messy when there are many images on it with different aspect ratios.
Comment 1 Eric Koegel editbugs 2013-08-11 09:36:06 CEST
Created attachment 5120 
icon label alignment

This patch will hopefully fix the icon label alginment, additionally the icon label can be multi-line using some of the previously unused icon space.
Comment 2 Andrzej editbugs 2013-09-07 21:40:40 CEST
Hi Eric,

I wanted to test the patch (sorry for the delay) but it no longer applies to git/master. Do you have a branch with this patch you could push?
Comment 3 Eric Koegel editbugs 2013-09-08 06:30:32 CEST
Hey Andrzej,
  It was in the eric/icon-changes branch and that got merged to master about a week ago. So it's in master here: http://git.xfce.org/xfce/xfdesktop/commit/?id=e2af8b45c6bb1a7f18cd8ac36c072fd024cfa664
  Let me know if that doesn't do what you envisioned.
Comment 4 Andrzej editbugs 2013-09-08 22:44:06 CEST
Hi, I'm still seeing misaligned labels. See the attached screenshot. Not sure if something has changed - it's been a while since my original report.
Comment 5 Andrzej editbugs 2013-09-08 22:45:02 CEST
Created attachment 5147 
label alignment
Comment 6 Eric Koegel editbugs 2013-09-09 13:44:00 CEST
Created attachment 5150 
screen shot

Here's what it looks like on my machine. Can you paste in xfdesktop -V and any revelant changes to your ~/.gtkrc-2.0? Then I can figure out what I did wrong.
Comment 7 Andrzej editbugs 2013-09-09 23:10:41 CEST
Hi Eric. Sorry! I must have been using wrong branch or have not restarted xfdesktop properly. With 4.10.0git-6f246d0 I am now getting the same layout as on your screenshot.
Comment 8 Eric Koegel editbugs 2013-11-27 01:41:05 CET
I'm assuming you're happy with the changes, closing bug report.

Bug #8646

Reported by:
Andrzej
Reported on: 2012-04-07
Last modified on: 2013-11-27

People

Assignee:
Eric Koegel
CC List:
3 users

Version

Version:
Unspecified

Attachments

icon label alignment (10.70 KB, patch)
2013-08-11 09:36 CEST , Eric Koegel
no flags
label alignment (8.89 KB, image/png)
2013-09-08 22:45 CEST , Andrzej
no flags
screen shot (29.63 KB, image/png)
2013-09-09 13:44 CEST , Eric Koegel
no flags

Additional information