! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar should provide an appicon larger than 48px
Status:
RESOLVED: FIXED
Severity:
enhancement

Comments

Description Simon Steinbeiss editbugs 2012-04-03 14:25:55 CEST
With most desktops (and following them: distributions) seem to go towards larger application-icons I think it'd be time to overthink Thunar's hardcoded 48px appicon.
(For reference, it's hardcoded here: http://git.xfce.org/xfce/thunar/tree/thunar/thunar-window.c?id=2147190c02c2ece7a924752a8d63bcf45e5568af#n2421)

Since Xfwm4 has gained the ability to show larger icons in tabwin (alt-tab), it'd be nice to see Thunar support this as well by no longer hardcoding the appicon but by using the highest-available resolution.
Comment 1 Jannis Pohlmann editbugs 2012-04-15 18:08:05 CEST
Fixed in master:

commit 096f3b6eb37205b6cabb0da4ecc8886b24a67a28
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Sun Apr 15 17:07:15 2012 +0100

    Add an 64x64 and 128x128 icon for Thunar (bug #8626).
Comment 2 Jannis Pohlmann editbugs 2012-04-15 18:51:26 CEST
Oops, I assumed the bug was about something entirely different and then pushed an complete unrelated "fix". Embarrassing. I'm herewith re-opening the bug.
Comment 3 Jannis Pohlmann editbugs 2012-04-15 23:47:27 CEST
Ok, this time I've come up with a proper fix.

commit 16ab778bb7fd307f7ac35715a33283494373bce6
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Sun Apr 15 22:42:21 2012 +0100

    Move away from using a hard-coded size for window icons (bug #8626).
    
    The previous commit wasn't actually related to this bug. The problem
    here was that the xfwm4 tab window now allows themes to change the size
    of the displayed window icons but Thunar still hard-coded its own window
    icons to 48px.
    
    From this commit Thunar on uses thunar_file_get_icon_name(current_dir)
    to get an icon name for the current directory and and then calls
    gtk_window_set_icon_name() rather than asking ThunarIconFactory for a
    48px GdkPixbuf that cannot be scaled up nicely. This is ok because we
    only ever set icons for directories and for those ThunarIconFactory
    never returns anything but a GdkPixbuf based on an icon name anyway. It
    never returns a GdkPixbuf loaded from an absolute path or anything.

Bug #8626

Reported by:
Simon Steinbeiss
Reported on: 2012-04-03
Last modified on: 2012-04-15

People

Assignee:
Jannis Pohlmann
CC List:
0 users

Version

Attachments

Additional information