! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Pointer settings and xfsettingsd don't compile on Solaris 10
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Mouse Settings

Comments

Description Peter Tribble 2012-03-30 22:45:50 CEST
As of the 4.9.x development release, xfce4-settings no longer compiles on Solaris 10.

The problem is the calls to

XListDeviceProperties
XGetDeviceProperty
XChangeDeviceProperty

in xfsettingsd/pointers.c and dialogs/mouse-settings/main.c

Now, the mouse-settings dialog not working I can live with (it never actually worked on Solaris anyway, it has a runtime version check that will always fail, but it used to compile).

However, the xfsettingsd problem is a bit more fundamental. (!)

The problematic code seems to have been introduced with synaptics support.

I can, without too much effort, manually ifdef out the troublesome code in xfsettingsd/pointers.c (at least xfce_pointers_helper_change_property, xfce_pointers_helper_change_properties, xfce_pointers_helper_syndaemon_check, xfce_pointers_helper_finalize, xfce_pointers_helper_syndaemon_stop, xfce_pointers_helper_class_init) and xfsettingsd/main.c (any reference to pointer_helper).

However, is there any simple way to add a --disable-syndaemon option to configure to turn all this off properly?
Comment 1 Nick Schermer editbugs 2012-03-31 18:02:57 CEST
What version of xinput does Solaris have?
Comment 2 Peter Tribble 2012-03-31 18:22:36 CEST
(In reply to comment #1)
> What version of xinput does Solaris have?

Solaris 10 is X11R6 based, so while it has xinput, it doesn't have a specific version number.

If I run xfce4-mouse-settings under xfce 4.8 it reports

(xfce4-mouse-settings:4481): xfce4-mouse-settings-CRITICAL **: Your XI is too old (1.3) version 1.4 is required.

(I'm not exactly sure what the difference between Xi and Xinput is.)

So the mouse settings has never worked; the new problem here is that xfsettingsd won't even compile.
Comment 3 Nick Schermer editbugs 2012-03-31 18:36:23 CEST
Could you attach XI.h, XInput.h and XIproto.h
Comment 4 Peter Tribble 2012-03-31 18:42:34 CEST
Created attachment 4285 
Solaris 10 XI.h
Comment 5 Peter Tribble 2012-03-31 18:43:02 CEST
Created attachment 4286 
Solaris 10 XInput.h
Comment 6 Peter Tribble 2012-03-31 18:43:24 CEST
Created attachment 4287 
Solaris 10 XIproto.h
Comment 7 Peter Tribble 2012-03-31 18:44:16 CEST
Attached all 3 include files from my Solaris 10 system as requested.
Comment 8 Nick Schermer editbugs 2012-04-01 11:54:37 CEST
Ok compilation should be fixed in master rev 337f428.

Now I'm not sure why we require Xi 1.4, I just enabled that at some point. In master (and I'll make a new release for pre1 as well) there is a new file xfsettingsd/pointers-defines.h, maybe you can set MIN_XI_VERS_MINOR to 3 and see what work in Solaris.

If you will, please open a new bug so we can figure out what to disable if Xi 1.3 is found (if needed at all).

Bug #8611

Reported by:
Peter Tribble
Reported on: 2012-03-30
Last modified on: 2012-04-01

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Attachments

Solaris 10 XI.h (7.92 KB, text/plain)
2012-03-31 18:42 CEST , Peter Tribble
no flags
Solaris 10 XInput.h (31.27 KB, text/plain)
2012-03-31 18:43 CEST , Peter Tribble
no flags
Solaris 10 XIproto.h (33.96 KB, text/plain)
2012-03-31 18:43 CEST , Peter Tribble
no flags

Additional information