! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Timeout doesn't work when smaller than fading time
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
major
Product:
Xfce4-notifyd
Component:
general

Comments

Description Yves-Alexis Perez editbugs 2012-03-18 16:06:25 CET 
It seems that the timeout (notify-send -t 5) just doesn't work.
Comment 1 Alec Moskvin 2012-06-11 18:34:14 CEST 
Created attachment 4498 
Patch to fix integer wrap-around for short timeouts

The problem is that when the timeout is smaller than the fading time (in this case, 5 ms vs. 800 ms), the subtraction causes the timeout to wrap around to a large number.

Here's a patch to fix that.
Comment 2 Yves-Alexis Perez editbugs 2012-06-11 19:48:02 CEST 
Good catch.
Comment 3 Jérôme Guelfucci editbugs 2012-12-08 16:24:05 CET 
Thanks for the bug report and the patch which I just pushed to git master.

I slightly modified it so that the timeout is set to FADE_TIME instead of 0 when it is smaller than FADE_TIME, that way you sill get to see the notification fading.

Bug #8580

Reported by:
Yves-Alexis Perez
Reported on: 2012-03-18
Last modified on: 2012-12-08

People

Assignee:
Jérôme Guelfucci
CC List:
1 user

Version

Version:
unspecified
Target Milestone:
---

Attachments

Patch to fix integer wrap-around for short timeouts (1.64 KB, patch)
2012-06-11 18:34 CEST , Alec Moskvin 		no flags

Additional information