8512 – Ristretto should report errors when an image can't be loaded

Ristretto should report errors when an image can't be loaded

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Ristretto

Component:

Application

Comments

Description Stephan Arts editbugs

2012-02-28 13:30:53 CET

Different downstream bugreport mention problems with ristretto not loading a specific image when the problem actually is inside gdk-pixbuf, or the mime-type not being detected correctly.

Ristretto should show a message to the user to indicate a failure.

Comment 1 Stephan Arts editbugs

2012-02-28 15:41:17 CET

Created attachment 4241 
Reports errors with broken images

This patch adds the feature to report image-loading errors to the user.

Comment 2 Stephan Arts editbugs

2012-02-28 16:02:27 CET

IMO: The image-viewer widget should show the error as a tooltip when there is one.

What do you think?

Comment 3 Stephan Arts editbugs

2012-02-28 16:55:24 CET

Created attachment 4242 
Report errors with broken images and show 'image-missing' icon.

Also, set the tooltip for the image-viewer widget.

Comment 4 Stephan Arts editbugs

2012-03-02 09:02:40 CET

This patch is applied to master and the 0.3 branch.

Comment 5 Simon Steinbeiss editbugs

2012-03-02 10:07:46 CET

i'm wondering whether it would be good to use the gtk infobar widget for that. at least it seems like a reasonable usecase for it.

Bug #8512

Reported by:
Stephan Arts

Reported on: 2012-02-28
Last modified on: 2012-03-02

People

Assignee:
Stephan Arts

CC List:
2 users

Version

Version:
master

Target Milestone:
---

Attachments

Reports errors with broken images (14.92 KB, patch) 2012-02-28 15:41 CET , Stephan Arts	stephan : review+
Report errors with broken images and show 'image-missing' icon. (17.00 KB, patch) 2012-02-28 16:55 CET , Stephan Arts	no flags

Additional information