! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
DuckDuckGo support through !bang syntax
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-verve-plugin
Component:
General

Comments

Description Isaac Schemm 2012-02-18 23:10:28 CET
Created attachment 4223 
DuckDuckGo support for xfce4-verve-plugin

Attached is a patch that will implement DuckDuckGo support for the verve plugin. Any command beginning with an exclamation point "!" will be processed as a DuckDuckGo search and launched as a URL with exo-open. DuckDuckGo supports many shortcuts to search other websites.
Examples:
"!g hello" - goes to Google to search for "hello"
"!g" - goes to the Google home page
"!wa 1024*1440" - has Wolfram Alpha calculate 1024*1440
"! homestar" (note the space) - goes to the first DuckDuckGo result for "homestar"
"!ddg test" - uses DuckDuckGo itself to search for "test"
The patch only has xfce4-verve-plugin use DuckDuckGo when the command begins with "!". Known bug: it also checks first to make sure the command isn't an executable in the PATH, but this is incomplete (it checks the whole command, including arguments, when it should just check the first component.)
Comment 1 Isaac Schemm 2012-03-28 01:05:37 CEST
Just an update. I added this support as well as some other features in a fork called xfce4-verve-plugin-ddg, available for Ubuntu in this PPA <https://launchpad.net/~libertyernie/+archive/xfce4-verve-plugin-ddg/> as well as source on github <https://github.com/IsaacSchemm/xfce4-verve-plugin>. Feel free to put some or all of the code into the main codebase if you would like. It's under the same license.
Comment 2 Landry Breuil editbugs 2012-12-30 18:55:58 CET
This is nice, but why supporting only DDG ? Note that you can also use smartbookmark plugin, which should more fit your needs since it's meant to send a command to a search engine (or rather, call any arbitrary url with a user-given parameter)
Comment 3 Isaac Schemm 2013-01-11 23:11:23 CET
(In reply to comment #2)
> This is nice, but why supporting only DDG ? Note that you can also use
> smartbookmark plugin, which should more fit your needs since it's meant to
> send a command to a search engine (or rather, call any arbitrary url with a
> user-given parameter)

Since I filed this bug report, I added support for other search engines. My reason for including DDG is so it could go there if a command started with "!" (a DDG shortcut) and perform its regular behavior otherwise.
Thank you for telling me about the smartbookmark plugin. My problem with it is that the size of the panel is limited to 10 characters, but I want my input box to fill almost the whole length of the panel row. I suppose I could just recompile it, but for now I'll stick with my modified verve plugin, so I can have one box instead of two.
Comment 4 Landry Breuil editbugs 2014-11-23 21:43:12 CET
Mass-reassign all bugs from florian@ to goodies-dev@, thanks for the maintenance work! (and sorry for the bugmail spam..)
Comment 5 Landry Breuil editbugs 2015-01-25 12:18:54 CET
Isaac, since you're maintaining your own fork on github and added quite some improvements on top, and verve-plugin in xfce doesnt really have a dedicated maintainer, do you want to take maintainership for it ? I'm looking at the attachment on the bug now and there's no point in merging only that part.


I'd be glad to transfer you ownership if you want. mail xfce4-dev@xfce.org or hop by #xfce-dev on freenode irc if you want more details on how to get an account.
Comment 6 Landry Breuil editbugs 2015-01-25 12:21:28 CET
Note: since per se your repo on github is not a proper 'git fork' of the repo of http://git.xfce.org/panel-plugins/xfce4-verve-plugin/, merging things will be a bit complicated, but i can help you on the boring parts by cherrypicking stuff.
Comment 7 Isaac Schemm 2015-01-27 02:44:05 CET
I can merge the changes in myself - then I'll get a good idea of what changes need to be made & if anything should be updated/cleaned up since I wrote them ~2 years ago. I'll be on xfce-dev periodically too.
Comment 8 Landry Breuil editbugs 2015-01-27 09:29:00 CET
I've made a 1.0.1 maintenance release of the last commits which were not pushed to users, as a start you can now rebase your commits on top of current git head.

To be able to push to git, mail accounts@xfce.org with an ssh public key and the username you want to use.
Comment 9 Landry Breuil editbugs 2015-02-05 17:54:46 CET
Fixed by http://git.xfce.org/panel-plugins/xfce4-verve-plugin/commit/?id=2dae40888dafd575186e78c30ae8480a16c83aa0, and yay for a new maintainer!
Comment 10 Steve Dodier-Lazaro editbugs 2015-02-08 18:38:20 CET
Yay.

Isaac, is there any chance you mail the developer mailing list to obtain ownership of the project on Bugzilla, and then that you update the milestones and versions for this project?

Thanks.

Bug #8485

Reported by:
Isaac Schemm
Reported on: 2012-02-18
Last modified on: 2015-02-08

People

Assignee:
Xfce-Goodies Maintainers
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information