! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Reschedule thumbnail requests after manually reloading a folder
Status:
RESOLVED: FIXED

Comments

Description Harald Judt 2012-02-16 07:01:27 CET
Created attachment 4209 
thunar-schedule-thumbnail-requests-on-reload.patch

Thumbnails often don't get regenerated in thunar. One should think that the file monitor should somehow invoke this when it detects a file change. But currently it doesn't, and manually reloading the folder doesn't help either.

Steps to reproduce:
1) Open a folder containing an image. A thumbnail should be generated.
2) Rotate the image with mogrify etc. from the command line (or gimp or a custom action, whatever).
3) Reload via toolbar, menu or keyboard shortcut.

Expected results:
The thumbnail will be regenerated on reloading.

Actual results:
The thumbnail will not be regenerated until the next time you revisit the folder or scroll up or down. Of course, the latter is not always possible. The old thumbnail will be shown, or sometimes even only the MIME icon.

The attached simple patch schedules the thumbnail requests after manually reloading the folder via the toolbar, the menu or the keyboard shortcut.
Comment 1 Harald Judt 2012-02-16 19:17:28 CET
Created attachment 4210 
thunar-thumbnail-request-on-selection-restore.patch

Ok, I got thumbnail generation sort of working for files modified outside of thunar, e.g. by a custom script or a terminal command.

Files added by something outside of thunar will still show the problem, though.
Comment 2 Harald Judt 2012-02-16 19:21:51 CET
Created attachment 4211 
thunar-thumbnail-request-on-row-deleted.patch

This helps a bit with some actions like deleting files. Doesn't catch all cases and is still of no use for new files.
Comment 3 Nick Schermer editbugs 2012-09-24 19:53:19 CEST
Fixed in 803adca and some previous commits.

Bug #8473

Reported by:
Harald Judt
Reported on: 2012-02-16
Last modified on: 2012-09-24

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information