! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Use lib instead of libexec and panel/plugins instead of panel-plugins
Status:
RESOLVED: FIXED
Product:
Xfce4-genmon-plugin
Component:
General

Comments

Description David Schneider 2012-02-15 01:00:36 CET
Created attachment 4199 
Patch for the bug.
Comment 1 Mike Massonnet editbugs 2012-02-15 06:45:18 CET
Don't install in /lib unless the plugin is compiled as a module. Genmon is compiled as an executable binary, therefore keep it in /libexec.
Comment 2 David Schneider 2012-02-15 07:15:44 CET
Odd. The exact same thing just happened for systemload (bug 7077)
Comment 3 David Schneider 2012-02-15 09:18:26 CET
Okay, so how about we make it compile as a module :)
Comment 4 David Schneider 2012-02-15 09:19:02 CET
Created attachment 4201 
Make it compile as a module
Comment 5 David Schneider 2012-02-15 10:33:13 CET
Created attachment 4203 
Removes the desktop.in.in indirection

We can remove the desktop.in.in as indirection thanks to this.
Comment 6 David Schneider 2012-02-15 10:33:49 CET
Created attachment 4204 
Gitignore for good measure
Comment 7 David Schneider 2012-02-16 01:29:20 CET
Created attachment 4208 
Bump the XDT requirement to 4.9.1

One last patch that bumps the XDT requirement to 4.9.1 (for libtool).
Comment 8 John Lindgren editbugs 2012-02-17 17:52:13 CET
(In reply to comment #0)
> Patch for the bug.

Patch for what bug?
Comment 9 Mike Massonnet editbugs 2012-02-17 19:48:15 CET
For this bug, check the bug subject.
Comment 10 John Lindgren editbugs 2012-02-17 21:05:05 CET
(In reply to comment #9)
> For this bug, check the bug subject.
Thank you but I have read the bug subject already and it does not say why there is a problem with the way things are done now, it only requests that they be done differently for some unknown reason.  Maybe I am missing something obvious?
Comment 11 David Schneider 2012-02-17 21:13:05 CET
libexec and REGISTER_EXTERNAL are deprecated.
Comment 12 Mike Massonnet editbugs 2012-02-25 11:48:36 CET
(In reply to comment #10)
> (In reply to comment #9)
> > For this bug, check the bug subject.
> Thank you but I have read the bug subject already and it does not say why there
> is a problem with the way things are done now, it only requests that they be
> done differently for some unknown reason.  Maybe I am missing something
> obvious?
Actually, there is nothing wrong the way it works currently:
- the location where the plugin files are installed
- the fact that it is compiled as an executable

Starting xfce panel 4.9, the location where the plugin is currently installed has been marked as deprecated but is still supported. What the newer version now suggests is to install the plugin under a new path for plugins compiled as a module.

NB: plugins compiled as executables have to be installed under libexec (packagers can tweak that under lib/package-name/)

The patch is hereby provided for these changes.
Comment 13 John Lindgren editbugs 2012-05-10 01:22:57 CEST
I've applied the two patches to compile as a module and remove the genmon.desktop.in.in indirection.  Thank you.
http://git.xfce.org/panel-plugins/xfce4-genmon-plugin/commit/?id=0c4c582e87f1f0b4b36782b3d4dc021bffce93df
http://git.xfce.org/panel-plugins/xfce4-genmon-plugin/commit/?id=e3b80386c076941bb43eac514143ab4a9d094b5b
Comment 14 David Schneider 2012-05-10 01:28:28 CEST
The XDT requirement patch is necessary for autogen.sh to work straight from git (older versions don't handle libtool properly; you have to run libtoolize or autoreconf -i manually).  It doesn't affect releases, since releases do not require XDT.
Comment 15 David Schneider 2012-05-10 01:30:47 CEST
Also, you can apply patches generated by git format-patch more easily using git am.

Bug #8468

Reported by:
David Schneider
Reported on: 2012-02-15
Last modified on: 2012-05-12

People

Assignee:
Florian Rivoal
CC List:
3 users

Version

Attachments

Patch for the bug. (2.26 KB, patch)
2012-02-15 01:00 CET , David Schneider
no flags
Make it compile as a module (4.35 KB, patch)
2012-02-15 09:19 CET , David Schneider
no flags
Removes the desktop.in.in indirection (2.68 KB, patch)
2012-02-15 10:33 CET , David Schneider
no flags
Gitignore for good measure (876 bytes, patch)
2012-02-15 10:33 CET , David Schneider
no flags
Bump the XDT requirement to 4.9.1 (621 bytes, patch)
2012-02-16 01:29 CET , David Schneider
no flags

Additional information