! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-screenshooter crashed with SIGSEGV in screenshooter_action_idle()
Status:
RESOLVED: FIXED
Product:
Xfce4-screenshooter
Component:
General

Comments

Description Lionel Le Folgoc 2012-02-11 16:01:56 CET
Created attachment 4185 
stacktrace

Hi,

An xubuntu user reported that xfce4-screenshooter crashed when trying to save a png file.

StacktraceTop:
 save_screenshot_to_local_path (screenshot=0x7feb43022a80, save_file=<optimized out>) at lib/screenshooter-dialogs.c:513
 save_screenshot_to (screenshot=0x7feb43022a80, save_uri=0x0) at lib/screenshooter-dialogs.c:612
 screenshooter_save_screenshot (screenshot=0x7feb43022a80, directory=0x7feb42ffce60 "file:/media/temp/Ubuntu.sumy.ua", title=<optimized out>, timestamp=<optimized out>, save_dialog=1, show_preview=0) at lib/screenshooter-dialogs.c:1137
 screenshooter_action_idle (sd=0x7feb42f98da0) at lib/screenshooter-actions.c:90
 g_main_dispatch (context=0x7feb42fdc6f0) at /build/buildd/glib2.0-2.30.0/./glib/gmain.c:2441
Comment 1 Lionel Le Folgoc 2012-02-11 16:10:03 CET
I couldn't reproduce the issue, but save_path/save_uri/save_file are NULL in this stacktrace. And contrary to what its documentation contains ("If error is set, FALSE will be returned"), gdk_pixbuf_save() returns NULL if filename == NULL without setting error... (http://git.gnome.org/browse/gdk-pixbuf/tree/gdk-pixbuf/gdk-pixbuf-io.c#n2387)

So xfce4-screenshooter probably crashes when accessing error->message later on...
Comment 2 Lionel Le Folgoc 2012-02-11 16:11:05 CET
(In reply to comment #1)
> gdk_pixbuf_save() returns NULL
                            ^^^^ sorry, I meant FALSE
Comment 3 Jérôme Guelfucci editbugs 2012-02-13 17:18:59 CET
Should be fixed in git master branch. I don't know how to return a NULL path from a file chooser so I could not test but it should be OK now.

Lionel, did you file a bug for the incorrect GNOME doc? I'll file it if not.

Cheers,

Jérôme

Bug #8443

Reported by:
Lionel Le Folgoc
Reported on: 2012-02-11
Last modified on: 2012-02-13

People

Assignee:
Jérôme Guelfucci
CC List:
0 users

Version

Version:
unspecified

Attachments

stacktrace (2.58 KB, text/plain)
2012-02-11 16:01 CET , Lionel Le Folgoc
no flags

Additional information