! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Set "small" property to match the icon size to other panel plugins in 4.9+
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
enhancement
Product:
Xfce4-mixer
Component:
Panel Plugin

Comments

Description Andrzej editbugs 2012-01-17 12:14:50 CET 
In 4.9+ xfce4-panel the icon-like plugins typically occupy 1 row to allow multi-row panels/deskbars.

This is done by setting "small" property to "TRUE" (default "FALSE") and size requisition to panel size / nrows.
Comment 1 Andrzej editbugs 2012-01-17 12:16:58 CET 
Created attachment 4105 
A patch implementing this feature.

Includes panel version checking for compatibility with 4.8.
Comment 2 Andrzej editbugs 2012-01-23 15:54:14 CET 
Created attachment 4121 
A patch implementing this feature (rev.2)

- compatible with libxfce4panel < 4.8 (in case if needed)
- corrected button size.
Comment 3 Harald Judt 2012-05-19 16:05:38 CEST 
Created attachment 4438 
xfce4-mixer-plugin-single-row.patch

Ok, I could have saved me some work by finding this bug earlier. My solution is only slightly different in that it does not send an additional (unneeded?) size request.
Comment 4 Andrzej editbugs 2012-05-19 16:29:08 CEST 
That was one of the earliest plugins I patched (hence the ugly macros).

But AFAIR button/icon size was a bit off if I didn't set the button size request. I didn't bother checking what's going on (an unrelated bug, or just my bad day?), setting the button size request request fixed that.
Comment 5 Guido Berhoerster 2012-09-28 13:08:30 CEST 
Fixed in commit f0e810321ef39e0ab57b567469b3785626f7cffc.

Bug #8350

Reported by:
Andrzej
Reported on: 2012-01-17
Last modified on: 2012-09-28

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
Unspecified
Target Milestone:
---

Attachments

A patch implementing this feature. (1.38 KB, patch)
2012-01-17 12:16 CET , Andrzej 		no flags
A patch implementing this feature (rev.2) (1.46 KB, patch)
2012-01-23 15:54 CET , Andrzej 		no flags
xfce4-mixer-plugin-single-row.patch (1.82 KB, patch)
2012-05-19 16:05 CEST , Harald Judt 		no flags

Additional information