! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Fixes custom icons for desktop files.
Status:
RESOLVED: FIXED
Priority:
Very Low
Severity:
enhancement
Product:
Xfdesktop
Component:
General

Comments

Description Eric Koegel editbugs 2012-01-10 18:49:22 CET
Created attachment 4096 
Fixes custom icons for desktop files.

The previous code looked for custom file icons in the
~/.thumbnails/ directory where the prefix matches the desktop file
icon, however the code wouldn't ever work. This patch scans the
thumbanil dir and loads a custom icon if there's a file that matches
the file name on the desktop. So a file on the desktop named foo
will have a custom icon loaded if the image in the .thumbnails dir
is foo.gif
Comment 1 Nick Schermer editbugs 2012-02-19 17:20:37 CET
Mm, I think we should rip this out. Non md5hash files in the .thumbnails directory is a bad idea.

The prefix-only check if a bit flawed as well, it can be improved with a dot-check (so foo2.png is not matched).
Comment 2 Eric Koegel editbugs 2013-09-30 09:08:15 CEST
The other broken code did get removed and this feature has been added to
xfdesktop using one of several file names inside the folder:
folder.jpg, cover.jpg, albumart.jpg, and fanart.jpg
With several variations for the spelling for most of them. This is semi-standard
with how most file managers/media browsers handle those images.
Added to master in:
http://git.xfce.org/xfce/xfdesktop/commit/?id=3b18c3b222314c65789006477a2f0e5e6d9e78c3

Bug #8326

Reported by:
Eric Koegel
Reported on: 2012-01-10
Last modified on: 2013-09-30

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
4 users

Version

Version:
Unspecified

Attachments

Additional information