! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
More themeable tabwin


Description Peter de Ridder editbugs 2011-12-11 13:17:31 CET
Created attachment 4020 
TabwinWidget object and border-width, icon-size styles

Adding support for theming the color border and icon size of the tabwin.
To support this the TabwinWidget needs to be a GtkWidget.

The attached patch makes TabwinWidget into a GtkWindow subtype.
It doesn't use G_DEFINE_OBJECT to be less intrusive patch.

The patch includes border-width and icon-size style property.
Comment 1 Simon Steinbeiss editbugs 2011-12-11 13:27:09 CET
the icon-size patch got me thinking that the ideal size of app-icons is related to (at least) two factors (which xfwm-tabwin already knows/uses to calculate the rows): screen estate/resolution and number of open windows.

personally i experience the 128px appicons that i'm using at the moment with xfwm4 as very productive on my (external) 1920x1200 screen. using my (internal) 1280x800 laptop resolution i'd probably go for 64px (at least when the icons start to overflow, i.e. >6). on 1280x800 i counted 6 icons per row with 128px and 12 with 64px. it's still nice to have the big icons in the switcher imo – even on the small resolution – but to avoid massive overflow it'd be nice to dynamically change the icon size.

maybe there are good solutions for the different use-cases, i guess i also have to give it more thought and it'd be nice to hear other people's thoughts on the matter.
Comment 2 Peter de Ridder editbugs 2011-12-11 23:04:38 CET
The idea of adding some inteligence to the screen size (reducing the icon size) got me thinking.
What about makeing the tabwin more rectangular?

Now the tabwin will increment in width until it takes up 75%, and adds rows afterwards.

As alternative, try to make the tabwin use multiple lines with lesser icons and gradually increment both width and height.
This kan be done in a way of a fixed aspect ratio or one to mimic the screen ratio.
Comment 3 Olivier Fourdan editbugs 2011-12-13 14:52:50 CET
Patch applied in git master.
Comment 4 Git Bot editbugs 2020-05-29 11:47:50 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/65.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #8238

Reported by:
Peter de Ridder
Reported on: 2011-12-11
Last modified on: 2020-05-29


Olivier Fourdan
CC List:
2 users




Additional information