! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] make multimedia keys working (audio volume/mail/www)
Status:
RESOLVED: WORKSFORME
Product:
Libxfce4ui
Component:
General

Comments

Description Rion 2011-11-26 18:07:35 CET
Created attachment 3985 
reuploaded patch

Fedora and SuSE (afaik) use this patch
http://pkgs.fedoraproject.org/gitweb/?p=libxfce4ui.git;a=blob_plain;f=libxfce4ui-4.7.6-keyboard-shortcuts.patch;hb=HEAD
for multimedia keys and some additional shortcuts.
It would be great if it applied to upstream.
Comment 1 Nick Schermer editbugs 2011-11-27 14:06:07 CET
Not all of them, some of those will still keys from other apps (like Print).
Comment 2 Rion 2011-11-27 14:11:06 CET
volume control and mute are more necessary for me.
Comment 3 Steve Dodier-Lazaro editbugs 2011-11-27 14:56:05 CET
Volume up/down/mute keys are managed by xfce4-volumed. If you want this one extended to multimedia keys in general, I'm open to discussion. I'm not sure if that wouldn't be conflicting with other deamons however.
Comment 4 Rion 2011-11-27 15:01:06 CET
xfce4-volumed sucks.
1) its additional app which is not required in case of proper key binding
2) its incompatible with xfce4-mixer
Comment 5 Rion 2011-11-27 15:06:00 CET
3) its shows stupid annoying notifications which do not disappear from system tray (latest libnotify)
Comment 6 Yves-Alexis Perez editbugs 2011-11-27 16:08:57 CET
(In reply to comment #4)
> xfce4-volumed sucks.
> 1) its additional app which is not required in case of proper key binding

Well, it's a tiny app, though maybe it could be integrated in xfce4-session or something like that. But that way you have the choice to run it or not.

> 2) its incompatible with xfce4-mixer

How incompatible?

(In reply to comment #5)
> 3) its shows stupid annoying notifications which do not disappear from system
> tray (latest libnotify)

Specific version? Seems to work fine here with libnotify 0.7.4
Comment 7 Rion 2011-11-27 16:25:27 CET
> Well, it's a tiny app, though maybe it could be integrated in xfce4-session or
> something like that. But that way you have the choice to run it or not.

integration sounds more appropriate. and I don't see any reason to not handle this keys. anyway proper key binding is still better solution.
it would be perfect if some app used only once(or by wish) to properly autodetect shortcuts.

> How incompatible?

xfce4-mixer panel applet does not show changes (no overlay indication on icon)

> Specific version? Seems to work fine here with libnotify 0.7.4

libnotify 0.7.4 as well. when I press mute key notification icon added to the tray and it stays there until I manually clear all notifications. Its highly annoying. and its not just fo me.
Comment 8 Steve Dodier-Lazaro editbugs 2011-11-27 22:30:10 CET
(In reply to comment #4)
> xfce4-volumed sucks.
> 1) its additional app which is not required in case of proper key binding

Explain me how a key binding can watch all the volume changes of a GStreamer track and notify you about them.

> 2) its incompatible with xfce4-mixer

There is a patch somewhere that should make Xfce4-mixer and Xfce4-volumed use the same track. We also agreed with the maintainer of Xfce4-mixer to speak about future plans for the apps soon.

However, you shouldn't have ANY problem if you never modified your sound card in Xfce4-mixer. If so, remove the active-track value from xfconf's xfce4-mixer channel, and it should work.
Comment 9 Steve Dodier-Lazaro editbugs 2011-11-27 22:33:53 CET
(In reply to comment #5)
> 3) its shows stupid annoying notifications which do not disappear from system
> tray (latest libnotify)

I've never ever had such a report. A user told me he was annoyed by the notifications lasting 10 seconds. If this is your definition of "do not disappear", then please go to the bug tracker of xfce4-volumed, complain a little there, and I'll tell you that I consider it a problem in xfce4-notifyd, and not of xfce4-volumed! :)
Comment 10 Rion 2011-11-27 22:38:17 CET
(In reply to comment #8)
> (In reply to comment #4)
> > xfce4-volumed sucks.
> > 1) its additional app which is not required in case of proper key binding
> 
> Explain me how a key binding can watch all the volume changes of a GStreamer
> track and notify you about them.

for what? I'm quite happy already w/o volumed.
Comment 11 Steve Dodier-Lazaro editbugs 2011-11-27 22:41:24 CET
(In reply to comment #7)
> integration sounds more appropriate. and I don't see any reason to not handle
> this keys. anyway proper key binding is still better solution.
> it would be perfect if some app used only once(or by wish) to properly
> autodetect shortcuts.

Jannis explicitly told me he wanted a stand-alone app for watching sound volume changes, and I must say I agree. It's a little more than just binding keys. So, ideally, keys would be bound by a xfce4 daemon that would make them available to other applications via some API, and would be able to give feedback to the user when several apps want to use a key, but we're not quite there yet and in the meanwhile I think xfce4-volumed is just fine (except for its ugly code :p).

> xfce4-mixer panel applet does not show changes (no overlay indication on icon)
>

Check my previous comment. Your setup is not normal (but I agree we'll have to apply this patch one day or another, to make it possible to control which track to display and control from the mixer's GUI).

> > Specific version? Seems to work fine here with libnotify 0.7.4
> 
> libnotify 0.7.4 as well. when I press mute key notification icon added to the
> tray and it stays there until I manually clear all notifications. Its highly
> annoying. and its not just fo me.

It's just for you as far as I know because I received an absolute 0 bug reports on this. Does this also happen on a clean installation of your current distribution (you can test in a virtual machine). And what exact versions of xfce4-volumed, xfce4-notifyd, libnotify are you using? What distribution are you using?
Comment 12 Rion 2011-11-27 22:42:01 CET
(In reply to comment #9)
> (In reply to comment #5)
> > 3) its shows stupid annoying notifications which do not disappear from system
> > tray (latest libnotify)
> 
> I've never ever had such a report. A user told me he was annoyed by the
> notifications lasting 10 seconds. If this is your definition of "do not
> disappear", then please go to the bug tracker of xfce4-volumed, complain a
> little there, and I'll tell you that I consider it a problem in xfce4-notifyd,
> and not of xfce4-volumed! :)

Yes. the problem is not in xfce4-volumed. I had similar bug in gnome.
so its bug in libnotify or in gentoo.
but it would be great if such notifications not used at all (tray icon is enough)
Comment 13 Rion 2011-11-27 22:52:56 CET
(In reply to comment #11)
> And what exact versions of
> xfce4-volumed, xfce4-notifyd, libnotify are you using? What distribution are
> you using?

xfce4-volumed-0.1.13
xfce4-notifyd is not installed
libnotify-0.7.4
gentoo ~
Comment 14 Yves-Alexis Perez editbugs 2011-11-27 23:06:08 CET
(In reply to comment #12)
> (In reply to comment #9)
> > (In reply to comment #5)
> > > 3) its shows stupid annoying notifications which do not disappear from system
> > > tray (latest libnotify)
> > 
> > I've never ever had such a report. A user told me he was annoyed by the
> > notifications lasting 10 seconds. If this is your definition of "do not
> > disappear", then please go to the bug tracker of xfce4-volumed, complain a
> > little there, and I'll tell you that I consider it a problem in xfce4-notifyd,
> > and not of xfce4-volumed! :)
> 
> Yes. the problem is not in xfce4-volumed. I had similar bug in gnome.
> so its bug in libnotify or in gentoo.
> but it would be great if such notifications not used at all (tray icon is
> enough)

Nobody forces you to use volumed, but if you divert from the default config then you should take care of that yourself, that's all.
Comment 15 Rion 2011-11-27 23:07:57 CET
(In reply to comment #14)
> (In reply to comment #12)
> > (In reply to comment #9)
> > > (In reply to comment #5)
> > > > 3) its shows stupid annoying notifications which do not disappear from system
> > > > tray (latest libnotify)
> > > 
> > > I've never ever had such a report. A user told me he was annoyed by the
> > > notifications lasting 10 seconds. If this is your definition of "do not
> > > disappear", then please go to the bug tracker of xfce4-volumed, complain a
> > > little there, and I'll tell you that I consider it a problem in xfce4-notifyd,
> > > and not of xfce4-volumed! :)
> > 
> > Yes. the problem is not in xfce4-volumed. I had similar bug in gnome.
> > so its bug in libnotify or in gentoo.
> > but it would be great if such notifications not used at all (tray icon is
> > enough)
> 
> Nobody forces you to use volumed, but if you divert from the default config
> then you should take care of that yourself, that's all.

I changed nothing notifications related.
Comment 16 Steve Dodier-Lazaro editbugs 2011-11-27 23:15:43 CET
> Nobody forces you to use volumed, but if you divert from the default config
> then you should take care of that yourself, that's all.

Actually it's been a while that we should have patched xfce4-mixer's GUI to be able to modify the track monitored by the panel plugin and managed by xfce4-volumed. I just don't remember why Jannis didn't apply it (so I have no clue who to blame :p).

Anyway I think we diverted enough from the topic of the bug report. My final comment on this will be: if you want to take volume key management out of xfce4-volumed, please report it to me on the bug tracker of xfce4-volumed, and give me good plans on where to move ALL the features of the app so that it can disappear to the heaven of pieces of software.
Comment 17 Yves-Alexis Perez editbugs 2011-11-27 23:19:27 CET
(In reply to comment #15)
> > > but it would be great if such notifications not used at all (tray icon is
> > > enough)
> > 
> > Nobody forces you to use volumed, but if you divert from the default config
> > then you should take care of that yourself, that's all.
> 
> I changed nothing notifications related.

Then you're using the default and see notification. End of story.
Comment 18 Rion 2011-11-27 23:25:47 CET
(In reply to comment #17)
> (In reply to comment #15)
> > > > but it would be great if such notifications not used at all (tray icon is
> > > > enough)
> > > 
> > > Nobody forces you to use volumed, but if you divert from the default config
> > > then you should take care of that yourself, that's all.
> > 
> > I changed nothing notifications related.
> 
> Then you're using the default and see notification. End of story.

sure =) broken notifications =) whih I don't want ot see =) and looks like there is no way disable them =)

Ok. if xfce4-volumed and xfce4-mixer will be by default properly configured and integrated and without these stupid popup notifications and additional tray icon from libnotify then I don't need anything else =)
Comment 19 Nick Schermer editbugs 2011-11-28 13:39:55 CET
Done now? I'll add the XF86Mail and XF86WWW keys. The Alt/Ctrl+## keys are not something standardized.

I have no idea if XF86Audio* keys would conflict with xfce4-volumd?
Comment 20 Steve Dodier-Lazaro editbugs 2011-11-28 14:31:55 CET
It's exactly those I used in xfce4-volumed.ku
Comment 21 Nick Schermer editbugs 2011-12-12 20:53:04 CET
Add shortcuts for XF86WWW and XF86Mail in 3130c3c.
Comment 22 Rion 2011-12-12 21:14:00 CET
gentoo devs added this patch as is.
so I'm quite happy now. everything works perfect w/o xfce4-volumed.
Comment 23 Roland Latour 2012-11-19 19:44:24 CET
1)xfce4-volumed has no manpage, doesn't even respond to the --help option.
2)is it for pulseaudio, or ALSA ? Most releases come with pulseaudio, but
many people routinely remove it. (it needs to DIAF)
3)IMHO shellscripts would be a more flexible approach anyway. See for
example http://user.cavenet.com/rolandl/PulseAudioScripts.tgz
4)Ref the above and ALSA, I'm working on scripts to implement that.
Problems:  I am using this in a shell script:
  vol=50
  notify-send -i info -t 3000 "Volume:  $vol %"

It works fine, up to a point, then fails with:
Error showing notification:
GDBus.Error:org.freedesktop.Notifications.MaxNotificationsExceeded:
Exceeded maximum number of notifications
Zenity --info truncates the string at the first space, and
Zenity --notification gets the same 'Exceeded max' error.

The only way I've found to stop this is to put 'Notifications'
in my XFCE panel and click on the icon next to NetworkMgr
and click on the button "Clear all notifications".
There's got to be a way to do that from the command line. (I've looked).

Notifications need a rethink. Why are they so persistent? And why can't
I have commandline control? Empower the users.
Comment 24 Nick Schermer editbugs 2013-03-19 19:17:25 CET
We added enough keys. volume is more of a distro things imho, so its for them to decide.

Bug #8194

Reported by:
Rion
Reported on: 2011-11-26
Last modified on: 2013-03-19

People

Assignee:
Nick Schermer
CC List:
5 users

Version

Attachments

reuploaded patch (1.78 KB, patch)
2011-11-26 18:07 CET , Rion
no flags

Additional information