! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
fix status icon for devices other than battery and ups (patch attached)


Description Daniel Schubert 2011-11-24 11:06:29 CET
Created attachment 3981 
remove additional dash from battery icon name

In xfce4-power-manager 1.0.10, whenever I plug in my Logitech Cordless Desktop LX 500, an "icon not found" icon appears in my systray. 

When I looked at the code, I noticed that xfpm_battery_refresh_icon incorrectly adds an additional dash to the icon prefix when the device is not a battery or a ups.

The attached patch (against git head) removes these dashes and adds an additional debug message.

As this is my first time filing a bug report, I hope everything is correct ;)
Comment 1 Alexei Colin 2012-01-22 18:14:39 CET
Daniel, thank you for the patch! This is just a thanks and a confirmation that it solved the ugly "icon not found" icon ofor my wireless mouse as well. For convenience, I uploaded a patched Oneiric package to ppa:alexei.colin/upower .
Comment 2 Jérôme Guelfucci editbugs 2012-12-19 14:05:43 CET
*** Bug 9039 has been marked as a duplicate of this bug. ***
Comment 3 Dean Montgomery 2013-01-04 23:12:34 CET
For my iphone charging status icon to show up properly I had to modify ~ Line 329 of xfpm-battery.c :

- else if ( battery->priv->state == XFPM_DEVICE_STATE_DISCHARGING )
+ else if ( battery->priv->state == XFPM_DEVICE_STATE_DISCHARGING || battery->priv->state == XFPM_DEVICE_STATE_CHARGING )
Comment 4 Dean Montgomery 2013-01-05 01:13:49 CET
Created attachment 4834 
Fix battery status indicator for mobile devices.
Comment 5 Simon Steinbeiss editbugs 2014-05-29 12:15:22 CEST
The trayicon has been removed from git master and the new panel-plugin handles this more gracefully, hence this bug has been fixed.

Bug #8188

Reported by:
Daniel Schubert
Reported on: 2011-11-24
Last modified on: 2014-06-16
Duplicates (1):
  • 9039 bad tray icon file name looked: "xfpm-keyboard--100.png"


Ali Abdallah
CC List:
6 users




Additional information