! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
exo-icon-chooser-dialog: allow removing selected icon
Status:
RESOLVED: MOVED

Comments

Description Jean-Philippe Fleury 2011-11-13 05:00:51 CET
1) In Thunar, go to "Edit > Configure custom actions...".

2) Choose an action that already has an icon and click on the "Edit" button.

3) Try to remove the icon, so the action would no longer have one.

Actual result: it's not possible. We only can choose another icon.

Expected result: we should be able to remove the icon, for example by choosing an item "No icon" in the drop-down list.
Comment 1 trtht 2012-06-18 04:08:18 CEST
Is the dropdown menu the best place to put the "no icon" option? If I submit a patch putting "No icon" right after the "All icons" menu, will it be accepted?
Comment 2 Ondrej Kulaty 2013-04-26 17:27:27 CEST
Created attachment 5012 
Fix for this bug
Comment 3 Ondrej Kulaty 2013-04-26 17:29:16 CEST
I have tried to fix this bug. Icon now can be
removed via a button which is shown next to the icon. If there is no icon set,
the button is hidden.
Comment 4 Nick Schermer editbugs 2013-05-15 21:11:18 CEST
The patch is fine (technically), but like you said, and "no icon" option in the combobox from the icon box would be a better solution, because then also the other components (xfce4-panel for example) would benefit from this.
Comment 5 Git Bot editbugs 2020-05-25 22:53:18 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/exo/-/issues/2.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #8139

Reported by:
Jean-Philippe Fleury
Reported on: 2011-11-13
Last modified on: 2020-05-25

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Version:
0.12.11

Attachments

Fix for this bug (3.34 KB, patch)
2013-04-26 17:27 CEST , Ondrej Kulaty
kulatyo+xfcebugzilla : review? ( jannis )

Additional information