! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Segmentation fault when paint_background_icon tries to use a NULL bg_...
Status:
RESOLVED: FIXED
Priority:
Low
Severity:
minor
Product:
Ristretto
Component:
Application

Comments

Description Eric Koegel editbugs 2011-11-11 14:11:20 CET 
Created attachment 3949 
Patch checks if(viewer->priv->bg_icon != NULL) before calling gdk_cairo_set_source_pixbuf in image_viewer.c

Output and backtrace:

(ristretto:31732): GdkPixbuf-CRITICAL **: gdk_pixbuf_saturate_and_pixelate: assertion `GDK_IS_PIXBUF (src)' failed

(ristretto:31732): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_width: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(ristretto:31732): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_height: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(ristretto:31732): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_pixels: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(ristretto:31732): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_rowstride: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(ristretto:31732): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_n_channels: assertion `GDK_IS_PIXBUF (pixbuf)' failed

Program received signal SIGSEGV, Segmentation fault.
IA__gdk_cairo_set_source_pixbuf (cr=0x7ffff6d7c9e0, pixbuf=<optimized out>, pixbuf_x=<optimized out>, pixbuf_y=<optimized out>) at /build/buildd/gtk+2.0-2.24.6/gdk/gdkcairo.c:255
255	/build/buildd/gtk+2.0-2.24.6/gdk/gdkcairo.c: No such file or directory.
	in /build/buildd/gtk+2.0-2.24.6/gdk/gdkcairo.c
(gdb) backtrace
#0  IA__gdk_cairo_set_source_pixbuf (cr=0x7ffff6d7c9e0, pixbuf=<optimized out>, pixbuf_x=<optimized out>, pixbuf_y=<optimized out>) at /build/buildd/gtk+2.0-2.24.6/gdk/gdkcairo.c:255
#1  0x000000000040ddc9 in paint_background_icon (widget=0x672340, ctx=0x7ffff6d7c9e0) at image_viewer.c:801
#2  0x000000000040efc3 in rstto_image_viewer_paint (widget=0x672340, ctx=0x7ffff6d7c9e0) at image_viewer.c:1213
#3  0x000000000040d4b8 in rstto_image_viewer_expose (widget=0x672340, event=0x7fffffffdd90) at image_viewer.c:517
#4  0x00007ffff78d7828 in _gtk_marshal_BOOLEAN__BOXED (closure=0x68cb90, return_value=0x7fffffffda40, n_param_values=<optimized out>, param_values=0x9e3a70, invocation_hint=<optimized out>, marshal_data=<optimized out>)
    at /build/buildd/gtk+2.0-2.24.6/gtk/gtkmarshalers.c:86
#5  0x00007ffff66360a4 in g_closure_invoke (closure=0x68cb90, return_value=0x7fffffffda40, n_param_values=2, param_values=0x9e3a70, invocation_hint=<optimized out>) at /build/buildd/glib2.0-2.30.0/./gobject/gclosure.c:774
#6  0x00007ffff6647e5f in signal_emit_unlocked_R (node=<optimized out>, detail=0, instance=0x672340, emission_return=0x7fffffffdba0, instance_and_params=0x9e3a70) at /build/buildd/glib2.0-2.30.0/./gobject/gsignal.c:3310
#7  0x00007ffff6651483 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=<optimized out>) at /build/buildd/glib2.0-2.30.0/./gobject/gsignal.c:3013
#8  0x00007ffff6651852 in g_signal_emit (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>) at /build/buildd/glib2.0-2.30.0/./gobject/gsignal.c:3060
#9  0x00007ffff79f1dc1 in gtk_widget_event_internal (widget=0x672340, event=0x7fffffffdd90) at /build/buildd/gtk+2.0-2.24.6/gtk/gtkwidget.c:4992
#10 0x00007ffff78d6080 in IA__gtk_main_do_event (event=0x7fffffffdd90) at /build/buildd/gtk+2.0-2.24.6/gtk/gtkmain.c:1682
#11 0x00007ffff7531704 in _gdk_window_process_updates_recurse (window=0x9dd5a0, expose_region=0x9e2a10) at /build/buildd/gtk+2.0-2.24.6/gdk/gdkwindow.c:5429
#12 0x00007ffff75316b3 in _gdk_window_process_updates_recurse (window=0x6736c0, expose_region=0x9b4e90) at /build/buildd/gtk+2.0-2.24.6/gdk/gdkwindow.c:5402
#13 0x00007ffff752c633 in gdk_window_process_updates_internal (window=0x6736c0) at /build/buildd/gtk+2.0-2.24.6/gdk/gdkwindow.c:5588
#14 0x00007ffff752e7d1 in IA__gdk_window_process_all_updates () at /build/buildd/gtk+2.0-2.24.6/gdk/gdkwindow.c:5696
#15 0x00007ffff7858f71 in gtk_container_idle_sizer (data=<optimized out>) at /build/buildd/gtk+2.0-2.24.6/gtk/gtkcontainer.c:1380
#16 0x00007ffff750bd26 in gdk_threads_dispatch (data=0x8ad380) at /build/buildd/gtk+2.0-2.24.6/gdk/gdk.c:512
#17 0x00007ffff6170a5d in g_main_dispatch (context=0x676040) at /build/buildd/glib2.0-2.30.0/./glib/gmain.c:2441
#18 g_main_context_dispatch (context=0x676040) at /build/buildd/glib2.0-2.30.0/./glib/gmain.c:3011

Bug #8135

Reported by:
Eric Koegel
Reported on: 2011-11-11
Last modified on: 2011-11-11

People

Assignee:
Stephan Arts
CC List:
0 users

Version

Version:
unspecified
Target Milestone:
---

Attachments

Patch checks if(viewer->priv->bg_icon != NULL) before calling gdk_cairo_set_source_pixbuf in image_viewer.c (1.03 KB, application/octet-stream)
2011-11-11 14:11 CET , Eric Koegel 		no flags

Additional information