! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Minor fixes so Ristretto will compile with full debugging enabled
Status:
RESOLVED: FIXED
Severity:
trivial
Product:
Ristretto
Component:
Application

Comments

Description Eric Koegel editbugs 2011-11-11 14:04:48 CET
Created attachment 3948 
When configuring --enable-debug=full several errors appear, this fixes those.

List of warnings that appeared when --enable-debug=full was set:
properties_dialog.c: In function ‘rstto_properties_dialog_init’:
properties_dialog.c:128:16: error: unused variable ‘notebook’ [-Werror=unused-variable]
properties_dialog.c: At top level:
properties_dialog.c:69:3: error: ‘RsttoExifProp’ defined but not used [-Werror=unused-variable]
xfce_wallpaper_manager.c: In function ‘rstto_xfce_wallpaper_manager_configure_dialog_run’:
xfce_wallpaper_manager.c:125:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
xfce_wallpaper_manager.c:126:5: error: dereferencing pointer to incomplete type
xfce_wallpaper_manager.c:127:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
util.c:26:1: error: no previous declaration for ‘rstto_launch_help’ [-Werror=missing-declarations]
util.c: In function ‘rstto_launch_help’:
util.c:36:5: error: implicit declaration of function ‘setlocale’ [-Werror=implicit-function-declaration]
util.c:36:5: error: nested extern declaration of ‘setlocale’ [-Werror=nested-externs]
util.c:36:35: error: ‘LC_MESSAGES’ undeclared (first use in this function)
util.c: In function ‘rstto_launch_help’:
util.c:106:1: error: control reaches end of non-void function [-Werror=return-type]

I commented out ‘notebook’, someone may have future plans for it...
Comment 1 Stephan Arts editbugs 2011-11-11 19:16:37 CET
Thanks, commited in http://git.xfce.org/apps/ristretto/commit/?id=c3bb5cc57e77fcd46fd18d1d17a914d584e3edd8

I removed the notebook, it is allowed to disappear since it is part of RsttoPropertiesDialogPriv now.

Bug #8134

Reported by:
Eric Koegel
Reported on: 2011-11-11
Last modified on: 2011-11-11

People

Assignee:
Stephan Arts
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information