! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
G_OPTION_FLAG_NO_ARG should not be used with G_OPTION_ARG_NONE
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfburn
Component:
general

Comments

Description Lionel Le Folgoc 2011-10-29 13:22:25 CEST 
Created attachment 3926 
Proposed patch

Hi,

In 0.4.3, in xfburn-main.c, the G_OPTION_FLAG_NO_ARG flag is passed to G_OPTION_ARG_NONE, and this leads to a few warning messages in .xsession-errors when launching xfburn:

(process:30887): GLib-WARNING **: /build/buildd-glib2.0_2.28.8-1-amd64-O6EeLn/glib2.0-2.28.8/./glib/goption.c:2132: ignoring no-arg, optional-arg or filename flags (8) on option of type 0

According to the glib api doc, G_OPTION_FLAG_NO_ARG can only be used with G_OPTION_ARG_CALLBACK, so I replaced it with no flag (0) and the warnings disappeared (see attached patch).

Thanks.
Comment 1 David Mohr 2012-04-16 00:10:30 CEST 
Applied, thanks!

commit 2d33493cea2fddeb6e287bcba5ba5b620d6cd48e
Author: David Mohr <david@mcbf.net>
Date:   Sun Apr 15 16:07:43 2012 -0600

    Applying patch by Lionel Le Folgoc (bug #8082)

Bug #8082

Reported by:
Lionel Le Folgoc
Reported on: 2011-10-29
Last modified on: 2012-04-16

People

Assignee:
Xfburn Bug Triage
CC List:
1 user

Version

Version:
0.4.3
Target Milestone:
---

Attachments

Proposed patch (850 bytes, patch)
2011-10-29 13:22 CEST , Lionel Le Folgoc 		no flags

Additional information