! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Use XDG_CONFIG_DIRS for the default config (new installs & migrations)
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-panel
Component:
General

Comments

Description Lionel Le Folgoc 2011-10-24 21:13:06 CEST
Hi,

Currently, xfce4-panel hardcodes its default config location to DEFAULT_CONFIG, e.g. during the migration, it only checks for this path.

That would be great if it could search it in XDG_CONFIG_DIRS too, with, e.g. xfce_resource_lookup (XFCE_RESOURCE_CONFIG, "xfce4/panel/default.xml").

I'm a bit ubuntu-centric on the rationale, but here it is: in ubuntu, several derivatives use Xfce by default (xubuntu, ubuntu studio, mythbuntu, linaro, etc.), and we can't share DEFAULT_CONFIG because each derivative has its own preferred settings. So instead, I patched xfce4-panel to look for the default config in XDG_CONFIG_DIRS (and fall back to DEFAULT_CONFIG when nothing is found), and each derivative ships its own default config in its own XDG_CONFIG_DIR.

I thought it might be interesting to have that by default.

What do you think?

Thanks.

(I attach the patch currently used against 4.8 for reference, but the "apply_vendor_settings" hackish part is already done cleanly in master with the use of the $XFCE_PANEL_MIGRATE_DEFAULT env var, so please ignore it ;-)
Comment 1 Lionel Le Folgoc 2011-10-24 21:13:39 CEST
Created attachment 3917 
Current workaround used
Comment 2 Nick Schermer editbugs 2011-10-25 08:01:39 CEST
Idea looks ok. About the $XFCE_PANEL_MIGRATE_DEFAULT var, can you folks work with that or should I drop it in favour of the != defaultconfig check?
Comment 3 Lionel Le Folgoc 2011-10-25 12:40:35 CEST
(In reply to comment #2)
> Idea looks ok. About the $XFCE_PANEL_MIGRATE_DEFAULT var, can you folks work
> with that or should I drop it in favour of the != defaultconfig check?

No, I think it's fine with $XFCE_PANEL_MIGRATE_DEFAULT. Thanks!

Bug #8067

Reported by:
Lionel Le Folgoc
Reported on: 2011-10-24
Last modified on: 2011-10-27

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
Unspecified

Attachments

Current workaround used (3.02 KB, patch)
2011-10-24 21:13 CEST , Lionel Le Folgoc
no flags

Additional information