! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Use XDG_DATA_DIRS for looking plugins
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description Mike Massonnet editbugs 2011-10-22 17:56:25 CEST
Hi Nick,

you think it's alright to use XDG_DATA_DIRS to check for directories with plugins? Currently the panel searches only in the prefix where it is installed (it seems), e.g. if you have the panel installed under the prefix /usr, you won't be able to install plugins under /usr/local.

Cheers,
Mike
Comment 1 Nick Schermer editbugs 2011-10-22 18:06:51 CEST
There is a reason behind this, XDG_DATA_DIRS shows the <prefix>/share directories, while the new-4.8 plugin location is in <prefix>/lib, so so get this, the panel could try base dirname($XDG_DATA_DIR) + "/lib/xfce4/panel/plugins", but that is a bit hackish since (does not happen often, i agree, but common on multi-arch systems), $libdir could be something else then $prefix/lib.

So I though when writing the 4.8 panel: "most distro's always choose the same prefix or a fixed $libdir", so I avoided the possible hackish behavior and used a fixed location.

It is easy to adjust in the code, but I doubt it is a good idea.
Comment 2 Samuli Suominen 2011-10-22 20:14:31 CEST
I thought that the .desktop files for plugins still get installed under /usr/share/xfce4/panel-plugins/ and then inside the .desktop files the X-XFCE-Exec= defines that path to /usr/lib/xfce/panel-plugins/

So with that logic, you'd look for $XDG_DATA_DIRS or $XDG_DATA_HOME/xfce4/panel-plugins/ for .desktop files, and check them for the actual plug-in path in libdir...

Did I miss something?
Comment 3 Nick Schermer editbugs 2011-10-22 20:16:46 CEST
Because of multi-arch systems, only the module name is stored in the desktop file (X-XFCE-Module), libexec modules are obsoleted.
Comment 4 Mike Massonnet editbugs 2011-10-26 16:08:17 CEST
Indeed, it corresponds to bug 5455.
Comment 5 Nick Schermer editbugs 2011-10-27 20:00:48 CEST
Fixed in ac15660.

Bug #8060

Reported by:
Mike Massonnet
Reported on: 2011-10-22
Last modified on: 2011-10-27

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
Unspecified

Attachments

Additional information