I'm using XFce on Gentoo GNU/Linux. Not long ago I needed to adaptate XFce for some windows users. Particularly it meaned, that I'v need to swich off virtual desktop feature. While reducing Virtual desktop number to 1 (I don't remember: always it appears or because of occasionally mouse click) the number of virtual desktops falls to zero, and xfwm4 crashed (and don't started at next boot (so I had to start it manually)). To my mind it will be good to set the minimal number of virtual desktops to 1 (or make this feature switchable and set minumal number of virtual desktops to 2).
Do you have some reproducing steps? I don't see xfce setting the workspace number to 0 (although I agree this should be checked, I wonder what would trigger this)
(In reply to comment #1) > Do you have some reproducing steps? I don't see xfce setting the workspace > number to 0 (although I agree this should be checked, I wonder what would > trigger this) 1. Goto settings menu virtual desktop management. 2. Decrease virtual desktop number from default 4 to target 1. 3. I'm not shure about was occasional double click at last step (from two to one) or not, but finall result was described. Perhaps, the same result could be achieved by decreasing virtula desktop number from 1 (if available, I don't remember it exactly).
There is already a test to check if the number of workspace is less that 0, see: http://git.xfce.org/xfce/xfwm4/tree/src/workspaces.c?h=xfce-4.8#n436 So I do not see that causing a crash, do you have a backtrace of the crash?s
But it crashes with any negative value, e.g. xfconf-query -c xfwm4 -p /general/workspace_count -s -1 Will crash it.
Should be fixed in git now, please test if possible and reopen if problem is still present.
(In reply to comment #3) > So I do not see that causing a crash, do you have a backtrace of the crash?s Yesterday I've made a test with recently stable amd64 version. And see no crash. But zero value (of virtual desktop number) is still available. To my mind it should be [available], and handle as "disabling feature of virtual desktops".
One more: it seems to be more correct to switch (on/off) feature with a checkbox. So, minimal virtual desktop number should be one (zero value must be unavailable) and available only if feature is on. It feature is disabled, virtual desktop number should be forcely set to value one (together with disabling some interface features).