! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
tumbler crashes when using gst-thumbnailer
Status:
RESOLVED: DUPLICATE
Product:
Tumbler
Component:
General

Comments

Description Mark Trompell 2011-09-21 12:39:54 CEST
tumbler crashes when trying to create a thumbnail using gst-thumbnailer:

$ /usr/lib/tumbler-1/tumblerd 

(tumblerd:22868): GStreamer-CRITICAL **: gst_mini_object_unref: assertion `GST_IS_MINI_OBJECT (mini_object)' failed
**
tumbler-gst-thumbnailer:ERROR:gst-thumbnailer.c:121:is_interesting: assertion failed: (GDK_IS_PIXBUF (pixbuf))

gst-plugins-bad=/foresight.rpath.org@fl:devel//2-devel/0.10.21-0.3-1[~!builddocs is: x86] (installed)
gst-plugins-base=/foresight.rpath.org@fl:devel//2-devel/0.10.35-0.1-1[~!builddocs is: x86] (installed)
gst-plugins-ffmpeg=/foresight.rpath.org@fl:devel//2-devel/0.10.11-0.1-1[~!builddocs is: x86] (installed)
gst-plugins-good=/foresight.rpath.org@fl:devel//2-devel/0.10.27-0.1-2[~!builddocs is: x86] (installed)
gst-plugins-ugly=/foresight.rpath.org@fl:devel//2-devel/0.10.17-0.1-3[~!builddocs is: x86] (installed)
gstreamer=/foresight.rpath.org@fl:2-devel/0.10.35-1-1[~!builddocs is: x86] (installed)
Comment 1 Jannis Pohlmann editbugs 2011-09-22 20:53:45 CEST
[Adding Ross to CC because he wrote the plugin.]

The error is in gst-thumbnailer.c:121 indeed. gst_helper_convert_buffer_to_pixbuf() may return NULL and the code doesn't check for that. This itself is rather easy to fix. However, I wonder what the reason might be for gst_helper_convert_buffer_to_pixbuf() to fail. Ross, do you have any idea?

BTW, I looked at the code of that helper function and it looks like it allocates stuff that it never releases in case of a failure (a lot of code paths return NULL without releasing the allocated GStreamer pipeline). I know gst-helper.c was copy-and-pasted for convenience but if it's so broken, we should replace it.
Comment 2 Mark Trompell 2011-09-27 09:39:35 CEST
Looks the same like 7996, although the fix there doesn't address the issues in Comment 1

*** This bug has been marked as a duplicate of bug 7996 ***

Bug #7994

Reported by:
Mark Trompell
Reported on: 2011-09-21
Last modified on: 2011-09-27

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
0.1.22

Attachments

Additional information