! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Panel fails to compile from git because of launcher (caused by 55783f562a0645...
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Launcher

Comments

Description Wes 2011-09-11 02:33:11 CEST
I think this has to do with the latest (55783f562a0645eb9032f53b1db039761a1d49b1) commit, as the previous one works fine and as this commit seems to be targeted at these same lines. This occurred with every combination of CFLAGS I tried, so I grabbed the previous commit, and the behavior was as usual (successful compilation). I tried to understand where the error is coming from, but after an hour of trying to teach myself enough C to fix this I'm a little stuck, even though I suspect the solution isn't that complicated. ;) Anyway, here is the full error:

make[4]: Entering directory `/home/veda/git/xfce4-panel/plugins/launcher'
  CC     liblauncher_la-launcher.lo
launcher.c:1187:1: error: static declaration of ‘launcher_plugin_save_delayed_timeout’ follows non-static declaration
launcher.c:1087:7: note: previous implicit declaration of ‘launcher_plugin_save_delayed_timeout’ was here
make[4]: *** [liblauncher_la-launcher.lo] Error 1
make[4]: Leaving directory `/home/veda/git/xfce4-panel/plugins/launcher'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/veda/git/xfce4-panel/plugins/launcher'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/veda/git/xfce4-panel/plugins'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/veda/git/xfce4-panel'
make: *** [all] Error 2

If you need config.log or anything else that could be helpful, let me know. As I said, the snapshot for the previous commit compiled with the same CFLAGS/config options.
Comment 1 Wes 2011-09-11 02:39:10 CEST
Created attachment 3861 
config.log for xfce4-panel, commit 55783f562a0645eb9032f53b1db039761a1d49b1
Comment 2 Wes 2011-09-11 02:40:23 CEST
This may be useful (I also went ahead and attached the log):

veda@neon:~/git/xfce4-panel$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/i386-linux-gnu/gcc/i686-linux-gnu/4.5.2/lto-wrapper
Target: i686-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 4.5.2-8ubuntu4' --with-bugurl=file:///usr/share/doc/gcc-4.5/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.5 --enable-shared --enable-multiarch --with-multiarch-defaults=i386-linux-gnu --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib/i386-linux-gnu --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.5 --libdir=/usr/lib/i386-linux-gnu --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-plugin --enable-gold --enable-ld=default --with-plugin-ld=ld.gold --enable-objc-gc --enable-targets=all --disable-werror --with-arch-32=i686 --with-tune=generic --enable-checking=release --build=i686-linux-gnu --host=i686-linux-gnu --target=i686-linux-gnu
Thread model: posix
gcc version 4.5.2 (Ubuntu/Linaro 4.5.2-8ubuntu4)
Comment 3 Nick Schermer editbugs 2011-09-11 08:02:20 CEST
Should be fixed in 55f1437.
Comment 4 Wes 2011-09-12 00:06:19 CEST
Yup, compiles fine now. Thanks!

Bug #7966

Reported by:
Wes
Reported on: 2011-09-11
Last modified on: 2011-09-12

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
Unspecified

Attachments

Additional information