! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
(volume) notifications are hidden with full screen applications
Status:
RESOLVED: FIXED

Comments

Description b3nmore 2011-08-27 13:27:39 CEST
Notification are not displayed (they are hidden), if an app (browser, movie player ...) is running in full screen mode. Only exception is the brightness notification.
One can now argue, that this is a feature and not a bug. But I think at least the notifications on volume changes/muting should be visible at all time
Comment 1 Brian J. Tarricone (not reading bugmail) 2011-09-26 09:11:53 CEST
This isn't up to the notifications daemon; the window manager is the ultimate arbiter of window stacking.  Xfce4-notifyd marks its windows as type 'notification', the WM decides they're less important than full-screen apps.

This has kinda annoyed me for a while, because there are some notifications I do want to see when running a full-screen app.  But then again, if I were doing a presentation on a projector or something, I'd want notifications to be hidden.  So it's a hard call.  Up to Olivier, really...
Comment 2 b3nmore 2011-11-06 10:24:08 CET
Apropos presentation, recently my notebook went quite unexpectedly into hibernation (as it should on critical power level), because the power manager notifications were hidden by a full screen pdf.
Comment 3 Jérôme Guelfucci editbugs 2012-12-05 21:37:28 CET
*** Bug 9375 has been marked as a duplicate of this bug. ***
Comment 4 Martin Renold 2014-02-05 17:53:42 CET
Note: "notify-send --urgency=critical Hello" still works in fullscreen.

Sadly, if you open new windows above your fullscreen window, it still counts as being in fullscreen.
Comment 5 xorgx3 2014-11-09 20:53:09 CET
Isn't workaround for this? Notifications are not working in the fullscreen for today.
Comment 6 hsumen 2015-03-24 20:06:48 CET
Counter to what was said in Comment #4, notify-send -u critical or --urgency=critical does not display over a full-screen window for me using either Openbox or xfwm4 and Debian jessie (xfce4-notifyd 0.2.4-3) . I'm using it as a battery notification from lxpanel and, since -u critical does not time out, I can end up with a screen full of notifications if I catch it before the computer shuts down.
Comment 7 Lars Luthman 2015-08-22 23:03:49 CEST
Created attachment 6427 
Patch to display notifications on top of fullscreen windows

Here's a patch that makes Xfwm4 recognise notifications as it's own type of window and display them above fullscreen windows. You can revert to the old behaviour (notifications below fullscreen windows) by adding the boolean configuration value /xfwm4/general/show_notifications_above_fullscreen with the value 'false'.
Comment 8 Lars Luthman 2015-08-22 23:07:24 CEST
Created attachment 6428 
Git-specific patch to display notifications above fullscreen windows

And here's the same patch in 'git am' format to preserve authorship information.

Both patches apply cleanly to the latest master, but I have only tried building it against xfwm4-4.10.1 as that is what I was using on Debian and I didn't want to install new incompatible dependencies.
Comment 9 Olivier Fourdan editbugs 2015-08-25 10:52:20 CEST
(In reply to Lars Luthman from comment #8)
> Created attachment 6428 
> Git-specific patch to display notifications above fullscreen windows
> 
> And here's the same patch in 'git am' format to preserve authorship
> information.
> 
> Both patches apply cleanly to the latest master, but I have only tried
> building it against xfwm4-4.10.1 as that is what I was using on Debian and I
> didn't want to install new incompatible dependencies.

Thanks for the patch!

Couple of comments:

 - Please make a clear and explicit commit message, and avoid a long topic for the first line. Also please refer to this bug in the commit message (you could take other commit messages as an example, even if not all are perfect, admittedly)

 - I reckon the layer for notifications should be called "WIN_LAYER_NOTIFICATION" rather than "WIN_LAYER_ABOVE_FULLSCREEN"

 - Please don't make it optional, either we want this or we don't, there is no need to add complexity to make this user configurable.
Comment 10 Lars Luthman 2015-08-25 12:21:12 CEST
Created attachment 6429 
Improved patch as per suggestions

Improved patch as per suggestions in comment #9. The configuration option is removed, the layer name is changed to WIN_LAYER_NOTIFICATION, the commit message is hopefully clearer and with neater formatting.
Comment 11 Yan Pas 2015-08-27 23:26:34 CEST
Built latest git, patch works fine. Tested over cs go (fullscreen mode) and Libreoffice. So even games do not crash/quit/minimize. Bug may be closed
Comment 12 Olivier Fourdan editbugs 2015-08-28 08:56:01 CEST
Merged in master a couple of days ago, thanks.

Bug #7928

Reported by:
b3nmore
Reported on: 2011-08-27
Last modified on: 2015-08-28
Duplicates (1):
  • 9375 Notification aren't visible is a window is in fullscreen mode

People

Assignee:
Olivier Fourdan
CC List:
9 users

Version

Version:
unspecified

Attachments

Additional information