! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix thunar segfaults in case of missing icons
Status:
RESOLVED: FIXED

Comments

Description Andreas Müller 2011-08-11 10:15:53 CEST
Created attachment 3818 
Patch: Fix segfaults if icons are missing or cannot be found

While implementing xfce 4.8 support on OpenEmbeedded I faced segfaults when starting thunar. Debugging lead to the reason: thunar is not prepared to work without icons. Attached is a patch making thunar more robust. It applies to master and 1.2.2. From my point of view no further efforts (error message) are required because one can see that the icons are missing :-)
Comment 1 Andreas Müller 2011-09-01 23:36:54 CEST
Any comments on the patch?
Comment 2 Jannis Pohlmann editbugs 2011-09-14 22:30:28 CEST
Thanks for the report and the fix. I've adjusted the indentation in your patch and comitted it to master and xfce-4.8 (below is the master commit). This will be in Thunar 1.2.3 and Thunar 1.3.1.

commit 2da5c8cfcccf484d6f39ff16cc0399859d1aff5e
Author: Andreas Mueller <schnitzeltony@gmx.de>
Date:   Thu Aug 11 10:00:33 2011 +0200

    Fix segfaults in case icons are missing or not found (bug #7880).
    
    Signed-off-by: Jannis Pohlmann <jannis@xfce.org>

Bug #7880

Reported by:
Andreas Müller
Reported on: 2011-08-11
Last modified on: 2011-09-14

People

Assignee:
Jannis Pohlmann
CC List:
0 users

Version

Attachments

Additional information