! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] thunar-vcs-plugin.so does not link to libapr but it needs to
Status:
RESOLVED: MOVED
Product:
Thunar-vcs-plugin
Component:
General

Comments

Description Natanael Copa 2011-07-29 09:36:14 CEST
on Alpine Linux I got this error:

/usr/bin/Thunar: symbol 'apr_uuid_parse': can't resolve symbol

(thunar:2582): thunarx-WARNING **: Failed to load plugin `thunar-vcs-plugin.so': unknown dl-error


nm -D | grep apr shows that plugin uses apr symbols:
                 U apr_ctime
                 U apr_initialize
                 U apr_pool_destroy
                 U apr_terminate

readelf -d shows that libapr is not linked:
 0x0000000000000001 (NEEDED)             Shared library: [libsvn_client-1.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libsvn_wc-1.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libsvn_fs-1.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libsvn_subr-1.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0.9.32]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.0.9.32]
 0x000000000000000e (SONAME)             Library soname: [thunar-vcs-plugin.so]

I suspect it works on glibc due to the indirect linking via the libsvn_* libs, but it does not work with uClibc.

looking at the Makefile.am shows that it actually tries to do the correct thing:
if HAVE_SUBVERSION
thunar_vcs_plugin_la_LDFLAGS +=                                         \
        $(APR_LDFLAGS)
endif


However APR_LDFLAS is wrong. It appears that the macros uses APR_LIBS. Replacing APR_LDFLAGS with APR_LIBS solves it.
Comment 1 Natanael Copa 2011-07-29 09:41:58 CEST
Created attachment 3801 
Fix linking to libapr
Comment 2 Git Bot editbugs 2020-05-20 21:33:15 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/thunar-plugins/thunar-vcs-plugin/-/issues/6.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #7850

Reported by:
Natanael Copa
Reported on: 2011-07-29
Last modified on: 2020-05-20

People

Assignee:
Peter de Ridder
CC List:
0 users

Version

Version:
unspecified

Attachments

Fix linking to libapr (909 bytes, patch)
2011-07-29 09:41 CEST , Natanael Copa
no flags

Additional information