! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
exo cleanup of deprecated functions
Status:
RESOLVED: WONTFIX

Comments

Description Christoph Mende 2011-07-07 19:17:26 CEST
I've replaced deprecated gtk+ functions in exo with their new versions, it compiles fine with -DG_DISABLE_DEPRECATED and -DGTK_DISABLE_DEPRECATED now.
Everything that was marked as deprecated in 2.20 is replaced, there are 2 functions marked as deprecated in 2.22 that I couldn't replace:
- gtk_dialog_set_has_separator, which defaults to FALSE in 2.22, so it can be removed as soon as 2.22 is required
- GTK_WIDGET_UNSET_FLAGS (widget, GTK_HAS_FOCUS) in exo/exo-private.c, line 68; GTK_WIDGET_UNSET_FLAGS is deprecated and should be replaced by other functions, but there is only gtk_widget_grab_focus which sets GTK_HAS_FOCUS, no function to unset it afaict.

Apart from that, most of this was pretty straightforward, but please take additional caution when looking over exo-helper-chooser.c, both changes (GtkTooltips -> gtk_widget_set_tooltip_text and gtk_button_released -> g_signal_emit_by_name) are a bit more complex than just replacement and especially with the signals, I'm not quite sure if it's correct. I've also left the old deprecated "released" signal in, because I don't know if it's used somewhere and I don't want to break API (the function is public).
Comment 1 Christoph Mende 2011-07-07 19:17:55 CEST
Created attachment 3774 
replace deprecated functions
Comment 2 Nick Schermer editbugs 2011-07-07 23:25:30 CEST
Same as bug #7793.

Bug #7792

Reported by:
Christoph Mende
Reported on: 2011-07-07
Last modified on: 2011-07-07

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
unspecified

Attachments

replace deprecated functions (35.90 KB, patch)
2011-07-07 19:17 CEST , Christoph Mende
no flags

Additional information