! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce_exec() doesn't handle quoted parameters properly
Status:
RESOLVED: FIXED
Product:
Libxfcegui4
Component:
General

Comments

Description Jasper Huijsmans editbugs 2005-02-18 12:11:25 CET
I haven't looked at the code yet, but after a user question about missing
entries for crossover office I found out that two things in the relevant
.desktop files caused the problem:

1) It was missing the Categories field. We should really just put those in 'Other'.

2) It use " quotes around the Exec= field (Exec="/opt/cxoffice/bin/wine" ...).
We should probably check for that, shouldn't we?
Comment 1 Jasper Huijsmans editbugs 2005-02-18 12:13:46 CET
To clarify, the quotes were around the executable, not the entire field. 

Exec="/opt/cxoffice/bin/wine" --check --cx-app "C://Program Files//Microsoft
Office//Office//WINWORD.EXE"
Comment 2 Brian J. Tarricone (not reading bugmail) 2005-02-18 18:36:15 CET
There *is* an Other menu, but I guess it isn't being used or set up properly.  I
guess I haven't looked at that code in a while, so I'm not sure what it's doing.

As for the quoting... this is really a PITA, and I don't think xfdesktop should
have to do this.  Since xfce_exec() is just taking command lines, it should
handle breaking up the commands into an argv array, and stripping any quoting as
needed.  If xfdesktop strips the quoting, and there's a space in one of the
arguments, it won't get executed properly.
Comment 3 Brian J. Tarricone (not reading bugmail) 2005-02-18 18:48:16 CET
#1 should be fixed on both branches, though i haven't tested beyond a compile test.

what do you think about #2?  i'd much rather see this fixed in xfce_exec().

(tsk tsk, two bugs in one report ^_~)
Comment 4 Jasper Huijsmans editbugs 2005-02-20 18:23:01 CET
(In reply to comment #3)
> #1 should be fixed on both branches, though i haven't tested beyond a compile
test.
> 

Yeah, I think so.

> what do you think about #2?  i'd much rather see this fixed in xfce_exec().
> 

Yeah, i agree, I'll have a look unless you do so first.

> (tsk tsk, two bugs in one report ^_~)

Hehe, I knew you were going to say that ;-) 

Comment 5 Jasper Huijsmans editbugs 2005-03-05 19:20:44 CET
Should be fixed now.

Bug #776

Reported by:
Jasper Huijsmans
Reported on: 2005-02-18
Last modified on: 2009-07-15

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information