! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Viewing a man page via #man in xfrun should not change the Run in Terminal ch...
Status:
RESOLVED: FIXED
Severity:
trivial
Product:
Xfce-utils

Comments

Description Hubert Hesse 2011-06-06 22:41:43 CEST
Viewing a man page in xfrun via #man should not change the "Run in Terminal" checkbox. xfrun4 currently enables the checkbox afterwards.
Comment 1 Hubert Hesse 2011-06-06 22:46:12 CEST
For convenience I pushed to patch here:
https://github.com/hubx/xfce-utils/tree/bug7702
Comment 2 Hubert Hesse 2011-06-06 22:48:04 CEST
Created attachment 3722 
Remember the state of in_terminal when using a #man page
Comment 3 Nick Schermer editbugs 2011-06-17 19:48:53 CEST
Fixed in 59777e3.
Comment 4 Hubert Hesse 2011-06-17 22:00:16 CEST
Thanks for your work Nick.
Why did you choose to disable the terminal checkbox for manpages always. Even if the checkbox was checked before?
I came across the same problem and decided the other way around that's why I'm curious.
Comment 5 Nick Schermer editbugs 2011-06-17 23:12:58 CEST
It's only for saving and doesn't matter (it will always try to open in a terminal).
Comment 6 Nick Schermer editbugs 2011-06-17 23:26:26 CEST
To put it a bit different; it's not going to make it more consistent if you save the "current terminal state" for each manual situation. Maybe for the next time the dialog shows, but not if you restore the history item after searching.

However it is more likely that people don't have terminal selected, so false is probably a better default.
Comment 7 Hubert Hesse 2011-06-17 23:48:22 CEST
"Maybe for the next time the dialog shows, but not if you restore the history item after searching."
fair enough. but maybe a worthwhile feature?

The reason I initial reported this bug was that the checkbox "run in terminal" changed if you viewed a man page via #man. This is still true if turn it off each time you view a #man page (instead of turning it on). That's why I kept the previous status.
Comment 8 Nick Schermer editbugs 2011-06-17 23:59:39 CEST
I know, but you still save a strange state in the history. And I guessed enabling is worse then disabling. With the new xfrun/appfinder you won't have this problem, since launch in terminal has been removed, strings prefixed with $ are launched in a terminal (or another prefix, you can eventually change that yourself).
Comment 9 Hubert Hesse 2011-06-21 18:08:27 CEST
(In reply to comment #8)
> I know, but you still save a strange state in the history. And I guessed
> enabling is worse then disabling. 
True from the developer point of view, but from the user point of view  not a valid argument.

If I run top with "Run in Terminal" enabled.
2. run #top to check further options on top (check box is still enabled here)
and then want to rerun top -option the check box not ticked anymore.

Maybe a better solution would be to skip #man like history entries to determine the status of the check box?
Comment 10 Hubert Hesse 2011-08-30 16:05:07 CEST
Still the cause of the altered check box is not clear to the user.
To put it in other words: I think the state of the history should reflect exactly what the user entered. That means “#man” with a checked check box should be saved in the history as such. The same applies for an unchecked check box.
Comment 11 Nick Schermer editbugs 2011-10-30 13:11:19 CET
This works fine in xfce4-appfinder now, since it does not have a checkbox anymore ;-).

Bug #7702

Reported by:
Hubert Hesse
Reported on: 2011-06-06
Last modified on: 2011-10-30

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
1 user

Version

Attachments

Additional information