! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
errors about gtk_progress_bar_set_fraction out of bounds
Status:
RESOLVED: FIXED
Product:
Xfce4-time-out-plugin
Component:
General

Comments

Description Petr Cerny [:hrosik] 2011-05-25 17:31:11 CEST
Created attachment 3696 
quick ugly fix for the symptoms

Most of the time time_out_lock_countdown_update() calls time_out_lock_screen_set_remaining() with arguments that are incompatible with gtk_progress_bar (resulting fraction to be set on the progress bar can range from infinity through zero to a number > 1), which in turn leads to GTK errors on stderr every second (when stderr goes into a log, it generates about 10MB/day).

The patch attached checks for these circumstances and disables update when it would result in the error. However, it is only a quick remedy and a proper solution should be used, as the problem seems to be rooted a little bit deeper. My suggestion would be either deregistering the lockdown timer after the break finishes and registering it again when a break starts or at least setting more reasonable values which are passed to the update functions outside of the break.

There is probably a similar problem with the countdown for the break start as well (which would generate errors during the break).
Comment 3 Petr Cerny [:hrosik] 2012-04-17 15:12:25 CEST
(In reply to comment #2)
> And better fix in
> http://git.xfce.org/panel-plugins/xfce4-time-out-plugin/commit/
> ?id=f6517ad3f4f168264242d57f40a0a692af895ef0

Thanks. Out of curiosity: does the first patch still has some function after this change?
Comment 4 Landry Breuil editbugs 2012-04-17 17:55:18 CEST
(In reply to comment #3)
> (In reply to comment #2)
> > And better fix in
> > http://git.xfce.org/panel-plugins/xfce4-time-out-plugin/commit/
> > ?id=f6517ad3f4f168264242d57f40a0a692af895ef0
> 
> Thanks. Out of curiosity: does the first patch still has some function after
> this change?

Yes it still ensures the gtk_progress_bar_set_fraction() receives valid arguments...
Comment 5 Landry Breuil editbugs 2012-06-11 19:24:32 CEST
*** Bug 9005 has been marked as a duplicate of this bug. ***

Bug #7660

Reported by:
Petr Cerny [:hrosik]
Reported on: 2011-05-25
Last modified on: 2012-06-11
Duplicates (1):
  • 9005 time-out plugin dies when it should lock

People

Assignee:
Landry Breuil
CC List:
4 users

Version

Attachments

quick ugly fix for the symptoms (1.98 KB, application/octet-stream)
2011-05-25 17:31 CEST , Petr Cerny [:hrosik]
no flags

Additional information