! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Terminal tabs look different to other tabs in xfce.
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-terminal
Component:
General

Comments

Description Lauri Hakko 2011-05-13 15:48:46 CEST
Created attachment 3668 
Tabs look different in terminal compared to other tabs such as midori and appearance settings dialog.

Tabs in xfce terminal look different to other tabs in xfce. In my current theme, the inactive tabs are lower to the active tab, but in terminal, they are all the same size.
Comment 1 Lauri Hakko 2011-05-13 15:51:53 CEST
Created attachment 3669 
Probable reason

Cause for this behaviour is suspected to be large close buttons on tabs, which force the tabs to be larger than in other applications.
Comment 2 Nick Schermer editbugs 2011-05-13 20:12:36 CEST
I really don't care unless you attach a working patch.
Comment 3 Lauri Hakko 2011-05-13 20:14:28 CEST
Created attachment 3670 
This patch fixes the issue.

Here is a patch to fix the issue. Terminal tabs should now look like all other gtk tabs.
Comment 4 Nick Schermer editbugs 2011-05-13 20:18:40 CEST
The result is that the terminal window gets bigger.
Comment 5 Lauri Hakko 2011-05-13 20:27:40 CEST
Only by few pixel, and terminal's tab look is consistent with other applications now.
Comment 6 perberos 2011-05-13 20:42:21 CEST
Created attachment 3671 
a working patch, taken from geany code

a working patch, taken from geany code
Comment 7 Nick Schermer editbugs 2011-05-30 22:54:43 CEST
Created attachment 3703 
Comparison with and without patch.
Comment 8 Mark Trompell 2011-05-31 09:19:00 CEST
(In reply to comment #7)
> Created attachment 3703 
> Comparison with and without patch.

I think that's how it's supposed to look.
Check with almost every program that uses tabs (except for terminal of course).
Comment 9 Nick Schermer editbugs 2011-06-04 10:32:52 CEST
Fix not convinced, I agree the tabs look nicer, but the border around the terminal window is ugly and makes the terminal resize.
Comment 10 Nick Schermer editbugs 2011-06-04 10:33:16 CEST
s/Fix/Still/
Comment 11 sankeytms 2012-03-20 03:37:05 CET
Created attachment 4271 
small tabs

Can we at least make the tabs smaller? I understand we are trying to keep the theme consistent with the rest of xfce, but if all the tabs in xfce are the same size as terminal, I'd go crazy (I don't use xfce).

Tabs should be the size of the current firefox tabs by defaut. If they are hard to see, that's what system DPI settings are for, right?
Comment 12 sankeytms 2012-03-20 03:52:44 CET
Created attachment 4272 
small tabs screenshot before and after

old on top/back, new on bottom/front.
Comment 13 Nick Schermer editbugs 2012-12-26 01:01:27 CET
Made a bit smaller, but not as small as you proposed. Same size as thunar.

Bug #7616

Reported by:
Lauri Hakko
Reported on: 2011-05-13
Last modified on: 2012-12-26

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information