hddtemp.c:120:2: error: invalid preprocessing directive #elseif Should be #elif , not elseif. I wonder how that one got into release. See also http://bugs.gentoo.org/show_bug.cgi?id=366833 for proposed patch.
Oh, just to make it clear, http://archive.xfce.org/src/panel-plugins/xfce4-sensors-plugin/1.2/xfce4-sensors-plugin-1.2.1.tar.bz2 has this error, not just version on gentoo mirrors.
google search for any documentation on elseif as preprocessor routine :) and it worked nicely without noticeable complaints on my system and compiler. anyway fixed in git since the day of release and first complaints on the mailing list.
Google search offers NO documentation on #elseif preprocessor directive. Furthermore, there are few resources stating that #elseif is an error. And there is no mention of elseif preprocessor directive in 2005-10-19 Working Draft for C++ (first one I happened to find), which means there is no such thing as #elseif in standard c++. Might be available in some compilers though, icc or msvcc. Not in gcc/g++ as of 4.5 that much I am sure. As for "working fine", it might be that you actually do not have HAVE_LIBNOTIFY7 flag set. In that case, preprocessor would just straight ignore everything between first #ifdef and #endif, including erroneous #elseif directive. Code safe, and keep up the good work. P.S. Would be good to see fix-release, not just "all good in git". But ah well, I understand that would be a violation of release schedule, which is apparently too much hassle for you. I just hope there are no poor sods who end up running into this bug, but lack knowledge to actually fix the problem.
(In reply to comment #3) > Google search offers NO documentation on #elseif preprocessor directive. So you know what I typed, that's cool. > P.S. Would be good to see fix-release, not just "all good in git". But ah well, > I understand that would be a violation of release schedule Which release schedule does the sensors plugin have???? > , which is apparently > too much hassle for you. You kidding? Released 1.2.0 and fix-release 1.2.1 the same day, bad argumentation. > I just hope there are no poor sods who end up running > into this bug, but lack knowledge to actually fix the problem. They will hopefully install libnotify0.4. Anyway, people using git or compiling on their own instead of using prepared (source) packages should really be able to do so, and some quickly dropped me a note. Everything's fine. Anyway 2, my personal release policy is to find out about the libtool stuff with ltmain.sh not being "compatible" on different systems with different libtool versions installed. Maybe tomorrow or in 2 weeks.
My point being, 1.2.1 source distribution at archive.xfce.org IS broken atm. Having libnotify 0.7 prevents it from building and with 0.4 it does not actually work like expected, since whole block is ignored. I am not sure why do you insist on leaving it there as it is, with no apparent alternative, but oh well. I guess I'm in no position to demand something. Nevermind my angry ramblings, by the way. Was not meaning to offend you.
(In reply to comment #5) > My point being, 1.2.1 source distribution at archive.xfce.org IS broken atm. fixed.
Thanks.