! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Don't filter <Alt>1 when there's only one tab open
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-terminal
Component:
General

Comments

Description Evangelos Foutras 2011-05-08 21:08:09 CEST
I usually keep irssi open in a terminal window and use the <Alt>1-9 shortcuts to switch between different IRC channels.

In gnome-terminal, I would press <Alt>1 to switch to the first channel. In Xfce's Terminal application, I can only use the <Alt>2-9 shortcuts to switch channels; <Alt>1 doesn't do anything.

I'm assuming <Alt>1 is interpreted by Terminal as a shortcut to switch to the first tab. However, when I only have a single tab open, I would prefer to have the key event passed to the application I'm running.

I'm using Terminal 0.4.7 on Arch Linux, and would find this change in behavior very useful.
Comment 1 Evangelos Foutras 2011-05-10 00:36:35 CEST
Created attachment 3662 
[PATCH] Only add tabs to the "Go" menu when num_tabs > 1

I made a patch that implements the behavior I personally find most useful. The patch appears to be somewhat long, but it's mostly whitespace changes. The main change is the introduction of the "if (npages > 1) { .. }" block.

I hope this can be merged into the repo (maybe with some modifications?).
Comment 2 Evangelos Foutras 2011-05-10 00:44:34 CEST
Same patch with the whitespace changes stripped: http://pastebin.com/raw.php?i=ZQRb2xHg (so you can see what it does much more easily).
Comment 3 Nick Schermer editbugs 2011-05-10 08:08:29 CEST
yes looks reasonable, will look into this and merge it.
Comment 4 Nick Schermer editbugs 2011-05-12 18:09:52 CEST
Fixed this slightly different in be9fca9.
Comment 5 Evangelos Foutras 2011-05-12 18:37:26 CEST
I like your fix much better.

Many thanks, Nick!

Bug #7595

Reported by:
Evangelos Foutras
Reported on: 2011-05-08
Last modified on: 2011-05-12

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information