! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Disable --as-needed on OpenBSD
Status:
RESOLVED: FIXED
Product:
Xfce4-dev-tools
Component:
General

Comments

Description Landry Breuil editbugs 2011-04-28 11:14:33 CEST
This should be reassigned to xfce4-dev-tools once there's a bugzilla component for it.

-Wl,--as-needed (ie linker opts) shouldn't be added when --enable-debug=full is used, as on OpenBSD things get messed up when --as-needed is used in conjunction with -pthread. See http://buildbot.xfce.org/builders/libxfce4util-openbsd/builds/14/steps/gmake%20distcheck/logs/stdio

Ideally, m4macros/xdt-features.m4 should do the AC_MSG_CHECKING([whether $LD accepts --as-needed]) only if uname is != OpenBSD, as done for adding -Wredundant-decls. Or conditionally add -Wl,--as-needed to LDFLAGS just below.
Comment 1 Landry Breuil editbugs 2011-04-28 21:44:24 CEST
Created attachment 3643 
don't check for --as-needed on OpenBSD

Quite intrusive one
Comment 2 Landry Breuil editbugs 2011-04-28 21:44:58 CEST
Created attachment 3644 
Don't add --as-needed to LDFLAGS on OpenBSD

smaller one
Comment 3 Nick Schermer editbugs 2011-04-28 22:02:34 CEST
Applied in 874bfb8.
Comment 4 Samuli Suominen 2011-07-09 02:57:50 CEST
I'm not reopening this but it seems like OpenBSD's pkg-config is packaged wrongly if this happens.   
It should be ./configured with --enable-indirect-deps to inherit -pthread where needed (that's what Gentoo's pkg-config is doing for FreeBSD).
Comment 5 Landry Breuil editbugs 2011-07-10 09:45:03 CEST
We don't use fd.o's pkg-config, but our own written in perl (which is 10x smaller, and doesn't depend on glib, etc..) - and it doesn't have support for 'indirect deps', whatever that is.

Bug #7546

Reported by:
Landry Breuil
Reported on: 2011-04-28
Last modified on: 2011-07-10

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Attachments

Additional information