! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Shift-dragging brings up contextual menu
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description akb825 2011-04-22 09:07:04 CEST
When dragging on the desktop while holding the shift key, the contextual menu is brought up. If you continue holding shift, when you dismiss the contextual menu with a click the selection rectangle shows up, and you can drag it until you click again. The expected behavior is to have the drag control a selection rectangle to add to the current selection.
Comment 1 Eric Koegel editbugs 2011-11-18 14:48:53 CET
Created attachment 3973 
This patch allows the shift + drag code to work by disabling the popup menu that happens duing a shift+click.

This will allow the current shift + drag/click code to actually do something useful. Currently, a shift + click will cause the root menu popup and that prevents the drag/click code from doing anything.
Comment 2 Eric Koegel editbugs 2011-11-19 07:21:18 CET
Created attachment 3977 
Fixes a minor bug in how shift+click selections are done.

This is a very minor patch to fix how shift + click selects icons. Along with patch 3973, shift + click or shift + drag should now work as expected. Both patches are required.
Comment 3 Eric Koegel editbugs 2011-12-02 14:30:00 CET
Created attachment 3996 
[PATCH] This enables the shift drag code to work properly.

This combines both previous patches into a single patch. It disables the popup on a shift click so the user can do a shift selection. It also fixes how shift selections were done, there was a trivial error in it.
Comment 4 Nick Schermer editbugs 2012-01-16 08:24:52 CET
Shift+1 is for 1 button mouses, so it is better to check if a drag is occurring, if so don't respond.
Comment 5 Eric Koegel editbugs 2012-02-07 15:42:33 CET
Created attachment 4170 
[PATCH] Fix for shift + drag selections

Right click and shift + left click will cause the root menu to pop up if no
dragging has occurred. This includes when shift + clicking on an icon, which
doesn't currently happen.

Bug #7525

Reported by:
akb825
Reported on: 2011-04-22
Last modified on: 2012-02-13

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
3 users

Version

Attachments

Additional information