! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
doesn't build anymore on kFreeBSD (xfce4-cpufreq-plugin.c:139: error: 'cpufre...
Status:
RESOLVED: FIXED
Product:
Xfce4-cpufreq-plugin
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2011-04-09 09:59:23 CEST
Hey,

we had a report that cpufreq plugin didn't build anymore on Debian GNU/kFreeBSD.

Downstream bug is at http://bugs.debian.org/621818 and build log at https://buildd.debian.org/status/fetch.php?pkg=xfce4-cpufreq-plugin&arch=kfreebsd-amd64&ver=1.0.0-1&stamp=1298816382

End of the log shows:

make[3]: Entering directory `/build/buildd-xfce4-cpufreq-plugin_1.0.0-1-kfreebsd-amd64-k33TIV/xfce4-cpufreq-plugin-1.0.0/panel-plugin'
gcc -DHAVE_CONFIG_H -I. -I..    -I.. -pthread -I/usr/include/xfce4/ -I/usr/include/xfce4 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/atk-1.0 -I/usr/include/xfce4 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/xfce4 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/atk-1.0 -DPACKAGE_LOCALE_DIR=\"/usr/share/locale\" -g -O2    -fstack-protector --param ssp-buffer-size=4  -D_FORTIFY_SOURCE=2  -Wformat -Wformat-security -Werror=format-security  -c -o xfce4_cpufreq_plugin-xfce4-cpufreq-plugin.o `test -f 'xfce4-cpufreq-plugin.c' || echo './'`xfce4-cpufreq-plugin.c
xfce4-cpufreq-plugin.c: In function 'cpufreq_restart_timeout':
xfce4-cpufreq-plugin.c:139: error: 'cpufreq_update_cpus' undeclared (first use in this function)
xfce4-cpufreq-plugin.c:139: error: (Each undeclared identifier is reported only once
xfce4-cpufreq-plugin.c:139: error: for each function it appears in.)
make[3]: *** [xfce4_cpufreq_plugin-xfce4-cpufreq-plugin.o] Error 1
make[3]: Leaving directory `/build/buildd-xfce4-cpufreq-plugin_1.0.0-1-kfreebsd-amd64-k33TIV/xfce4-cpufreq-plugin-1.0.0/panel-plugin'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/build/buildd-xfce4-cpufreq-plugin_1.0.0-1-kfreebsd-amd64-k33TIV/xfce4-cpufreq-plugin-1.0.0'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/build/buildd-xfce4-cpufreq-plugin_1.0.0-1-kfreebsd-amd64-k33TIV/xfce4-cpufreq-plugin-1.0.0'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
Comment 1 Yves-Alexis Perez editbugs 2011-04-09 10:02:05 CEST
And indeed cpufreq_update_cpus is only defined in xfce4-cpufreq-linux.{c,h}.
Comment 2 Yves-Alexis Perez editbugs 2011-04-09 14:13:00 CEST
Iirc you have some trouble coding stuff for BSD since you don't have access to such a machine.

In case you need it, http://people.debian.org/~aurel32/qemu/kfreebsd-i386/ and http://people.debian.org/~aurel32/qemu/kfreebsd-amd64 are standard Squeeze kFreeBSD machines (GNU userland, FreeBSD kernel). Everything should (more or less) work like a standard Debian.
Comment 3 Yves-Alexis Perez editbugs 2011-04-25 12:40:06 CEST
Created attachment 3639 
fix build failure on !linux

This fix the builds on non Linux arches but is a bit quick and dirty and I have no idea how the plugin will behaves.
Comment 4 Harald Judt 2013-08-19 22:49:51 CEST
I have applied the "fix". Though I wonder whether the current plugin version will work at all on other OSes?

http://git.xfce.org/panel-plugins/xfce4-cpufreq-plugin/commit/?id=0f1c82d42f020331b35cbce179dfd5af008b6de8

Bug #7482

Reported by:
Yves-Alexis Perez
Reported on: 2011-04-09
Last modified on: 2013-08-19

People

Assignee:
Harald Judt
CC List:
1 user

Version

Attachments

fix build failure on !linux (512 bytes, patch)
2011-04-25 12:40 CEST , Yves-Alexis Perez
no flags

Additional information