! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
FWD: <Safety> use after free in tumbler-manager.c
Status:
RESOLVED: FIXED
Product:
Tumbler
Component:
General

Comments

Description Philip Van Hoof 2011-03-16 15:46:20 CET
SOFTWARE VERSION:
tumbler 1:0.1.13-1+rq498670+0m6

/tumbler/tumblerd/tumbler-manager.c

line 1455 -- *list = g_list_delete_link (*list, lp);
line 1490 -- *list = g_list_delete_link (*list, lp);

lp is deleted in these lines but still using in line

1442       for (lp = *list; lp != NULL; lp = lp->next)


valgrind generate Invalid read errors for similar places

For people with access to this bugzilla:

https://projects.maemo.org/bugzilla/show_bug.cgi?id=235928
Comment 1 Philip Van Hoof 2011-03-16 15:47:32 CET
Created attachment 3567 
Proposed fix for upstream
Comment 2 Philip Van Hoof 2011-03-16 15:52:10 CET
Note that downstream this bug is marked as invalid, due to the patches that add #ifdef MONITOR_CONFIG isn't this code being used / never ran on the Harmattan platform.

The valgrind point the reporter makes is vague. I think he was seeing valgrind reporting about different lines. Perhaps a reopen will happen with the right lines, in which case I'll either fix those invalid reads (if they are relevant for Harmattan) and propose a patch. Or I'll again forward this info here or in a new bug.

Cheers
Comment 3 Jannis Pohlmann editbugs 2012-02-25 16:13:02 CET
I've pushed a similar but slightly different fix to master:

commit 3704cf3502bc8cafb4e7cd7956c0ae983a415b3e
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Sat Feb 25 15:09:30 2012 +0000

    Avoid accessing list elements after they have been freed (bug #7418).

Bug #7418

Reported by:
Philip Van Hoof
Reported on: 2011-03-16
Last modified on: 2012-02-25

People

Assignee:
Jannis Pohlmann
CC List:
0 users

Version

Version:
unspecified

Attachments

Proposed fix for upstream (1.76 KB, patch)
2011-03-16 15:47 CET , Philip Van Hoof
no flags

Additional information