Created attachment 3551
Simple bug: IMHO it looks better if window titles with the "full_width_title" option set to true are centered in the middle of the title bar.
The attached patch fixes this!
I agree with this :)
When moving buttons around in the titlebar, this is not taken into account when centering the window title. E.g. I like to have 3 buttons on the left and one on the right, the window title is now skewed to the right quite a bit.
I was looking into the title_horizontal_offset theme parameter, but as I found out in the sourcecode this parameter is not taken into account when using centered titles.
Adding cc's so that this doesn't get lost.
Well this got lost anyway.
What is that full_width_title setting actually supposed to do? Because at the moment it doesn't seem to have any effect on the visual appearance of the title bar.
Never noticed this until I watched this review of MX Linux. https://youtu.be/Gv_BkNvuNlE?t=250
The patch is available for the last 9 years, so is there any issue to getting this merged?
(In reply to Yousuf 'Jay' Philips from comment #4)
> Never noticed this until I watched this review of MX Linux.
> The patch is available for the last 9 years, so is there any issue to
> getting this merged?
The title is centered relative to the title area who's size varies depending on which buttons are enabled.
If we were to change that, it would need to be optional because the current behavior makes a lot of sense with many themes.
(In reply to Olivier Fourdan from comment #5)
> If we were to change that, it would need to be optional because the current
> behavior makes a lot of sense with many themes.
Can you identify some themes where this make sense, as it seems like it would be a bug in those themes.
(In reply to Yousuf 'Jay' Philips from comment #6)
> Can you identify some themes where this make sense, as it seems like it
> would be a bug in those themes.
I'm sorry that doesn't make any sense, how could that be a “bug in those themes”?
Any theme that distinguish the title area from the rest would look odd with a globally centered title.
(In reply to Olivier Fourdan from comment #7)
> I'm sorry that doesn't make any sense, how could that be a “bug in those
Guess we were misunderstanding each other
> Any theme that distinguish the title area from the rest would look odd with
> a globally centered title.
Okay that was a more specific. Can you mention any popular ones that are like this, as I cant find any.
In the base xfwm4 package, there's "Moheli".
Or a bunch of those from the "xfwm4-themes" package, like "Mofit" for example.
So i did some digging around with other DEs (Gnome, Mate, Cinammon, KDE) and only Xfce behaves in this manner, so I doubt theme designers, especially those who are creating cross-DE themes, would be wanting this behavior or are even aware of this Xfce-specific behaviour.
We have theme designers who are part of the dev team who could give their input to decide whether it should be the default or not, if you are willing to consider it.
-- GitLab Migration Automatic Message --
This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/54.
Please create an account or use an existing account on one of our supported OAuth providers.
If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests
Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev