! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce-desktop interface (xfdesktop --windowlist) allows easy mis-add/remove vi...
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Ikonta 2011-02-24 07:46:20 CET
Created attachment 3511 
XFce-4.8 switch desktop window

In my case switch desktop menu is invoked by mouse middle-button click.

This menu contains items for adding/removing virtual desktops. Without asking prompt for this action!

To my mind this actions should ad least ask prompt.
And, normally, this part of menu (two last lines) should not be normally displayed.
They should be removable by an option in 'Virtual Desktop Management' (excuse me, currently I'm using Russian localized system and can't put correct English name) 'Settings' submenu.
Comment 1 Ikonta 2012-08-25 19:02:13 CEST
XFce-4.10 on amd64: the same issue.
Comment 2 Ikonta 2013-03-05 12:55:42 CET
Window list is generated by xfdesktop utility (xfdesktop --windowlist).
Comment 3 Ikonta 2013-11-11 11:00:02 CET
Created attachment 5229 
patch to remove add/delete workstace lines from windowlist

Patch is well enough, now I'm thinking about tailing line-separator.

It would be pretty to manage this code via configure options (similiarly with complete disableing of windowlist feature).
Comment 4 Simon Steinbeiss editbugs 2013-11-26 13:44:41 CET
If you check xfdesktop from git, it does show a prompt asking whether you really want to remove a workspace if you use the window-list.
Comment 5 Ikonta 2013-11-27 07:21:15 CET
(In reply to Simon Steinbeiss from comment #4)
> If you check xfdesktop from git, it does show a prompt asking whether you
> really want to remove a workspace if you use the window-list.

I use current stable XFce release, so this checkout willn't be easy.
Prompt on remove as well enough, but it's just first step.
Mis-add workspace is also not pleasant.
Additionally, this way of workspace's handling is not fully functional (till add workspace prompt will'n ask also for workspace's name).

For newsettlers, migrating from classic windows this feature may be useful.
But I don't need in it, don't use it and strictly prefer not to see it.
Ideal solution for me will be to make it switchable (compile-time or runtime from main workspace-manage settings submenu).
Comment 6 Simon Steinbeiss editbugs 2013-11-27 10:42:20 CET
Created attachment 5243 
Screenshot of the current windowlist menu
Comment 7 Simon Steinbeiss editbugs 2013-11-27 10:45:11 CET
(In reply to Ikonta from comment #5)
> I use current stable XFce release, so this checkout willn't be easy.
> Prompt on remove as well enough, but it's just first step.
> Mis-add workspace is also not pleasant.

Frankly, I don't see how mis-adding of a workspace is more unpleasant than any other mis-click in that menu. It simply results in some correcting clicks (e.g. if you mis-click and go to the wrong Firefox window on the wrong workspace, you also have to click a few times to get back to the one you wanted).

> Additionally, this way of workspace's handling is not fully functional (till
> add workspace prompt will'n ask also for workspace's name).

The prompt does show the name of the workspace you're currently on and the one that is going to be removed. So this concern is fully taken care of.

> For newsettlers, migrating from classic windows this feature may be useful.
> But I don't need in it, don't use it and strictly prefer not to see it.
> Ideal solution for me will be to make it switchable (compile-time or runtime
> from main workspace-manage settings submenu).

It's not my call, as I'm not xfdesktop's maintainer, but I really think adding an option simply to hide two menuitems is a bit overkill...
Comment 8 Ikonta 2013-11-29 12:17:00 CET
(In reply to Simon Steinbeiss from comment #7)
> Frankly, I don't see how mis-adding of a workspace is more unpleasant than
> any other mis-click in that menu.
Easily.
To make a mis-click in menu I must first open this menu.

But windowlist I use ordinarly, to switch between windows/applications/workspaces.
So, I just mispointing mouse leads to menu's mis-click.

> The prompt does show the name of the workspace you're currently on and the
> one that is going to be removed. So this concern is fully taken care of.
Asking about workspace's name is wanted also on adding workspace.

> > For newsettlers, migrating from classic windows this feature may be useful.
> > But I don't need in it, don't use it and strictly prefer not to see it.
> > Ideal solution for me will be to make it switchable (compile-time or runtime
> > from main workspace-manage settings submenu).
> 
> It's not my call, as I'm not xfdesktop's maintainer, but I really think
> adding an option simply to hide two menuitems is a bit overkill...

Maybe.
It was really not very difficult to get a personal patch, doing so.
Comment 9 Eric Koegel editbugs 2013-12-23 17:56:40 CET
There's an option in master now to disable the add and remove workspace buttons. The commit id is: f12aa431c11f4aac2e9805f68e2f1d5b5424e079 and there's also an option in xfdesktop-settings. Closing bug.

Bug #7337

Reported by:
Ikonta
Reported on: 2011-02-24
Last modified on: 2013-12-23

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
3 users

Version

Version:
4.10.0

Attachments

Additional information