7267 – exo-0.6.0 (and git): Only compile tests with 'make check'

exo-0.6.0 (and git): Only compile tests with 'make check'

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
minor

Product:
Exo

Component:

General

Comments

Description Samuli Suominen 2011-02-10 19:41:17 CET

Some tests in tests/Makefile.am build despite of not calling 'make check' lenghtening the default compile time for exo.

This:

noinst_PROGRAMS =                                                       \
        test-exo-icon-chooser-dialog                                    \
        test-exo-wrap-table

Should propably be:

check_PROGRAMS =                                                        \
        test-exo-icon-chooser-dialog                                    \
        test-exo-wrap-table

Simple change from noinst to check.

Not really a major issue but consider that this gets built on every user everytime they install the package on source based distro...

Thanks!

- Samuli

Comment 1 George McCollister 2011-02-11 17:32:51 CET

It also tries to run the test binaries which fails when cross compiling. In order to get it cross compiling for ARM without errors I had to hack out tests from Makefile.am and run autoreconf. In general it's bad practice to run created binaries in configure, make or make install without providing an override mechanism.

Comment 2 Nick Schermer editbugs

2011-02-12 17:59:53 CET

Fixed in ac27ea6.

Comments

Bug #7267

People

Version

Attachments

Additional information