! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xffm crashes if the fstab-module is used under solaris.
Status:
RESOLVED: FIXED

Comments

Description Joel Fredrikson 2005-01-19 19:10:03 CET
Choosing the fstab-module in xffm under solaris results in 

xffm: signal 11 received. Cleaning up before exiting
xffm: logfile = /home/ittest1/.cache/xfce4/xffm/xffm_error.log
xffm: dumping core at= /home/ittest1/.cache/xfce4/xffm

The problem is located in the solaris-variant of open_fstab() in
modules/fstab-module.c.

A counter is prematurly increased which results in a SIGSEGV.

Excerpt from the code

   i++;
   /*
    * Check if filesystem is already mounted
    *
    */
   (void)rewind(mnttab_fp);
   for (;;) {
      if (getmntent(mnttab_fp, &mbuf) != 0)
         break;

      if (strcmp(mbuf.mnt_mountp, vbuf.vfs_mountp) == 0)
         TOGGLE_MOUNTED(fstat_xfdir.gl[i].en->type);
   }

The fix is basically to move the "i++;" after the for()-loop.


Reproducible: Always
Steps to Reproduce:
1. Start xffm
2. Doubleclick on "Fstab"
3.
Comment 1 Joel Fredrikson 2005-01-19 19:10:47 CET
Created attachment 159 
Suggested patch
Comment 2 Joel Fredrikson 2005-01-19 19:17:38 CET
Created attachment 160 
Currected patch

Sorry, previous patch is bad.
Comment 3 edscott editbugs 2005-01-19 19:40:02 CET
Patch has been applied to CVS. Thanks!

Bug #726

Reported by:
Joel Fredrikson
Reported on: 2005-01-19
Last modified on: 2009-07-14

People

Assignee:
edscott
CC List:
0 users

Version

Version:
unspecified

Attachments

Suggested patch (640 bytes, patch)
2005-01-19 19:10 CET , Joel Fredrikson
no flags
Currected patch (858 bytes, patch)
2005-01-19 19:17 CET , Joel Fredrikson
no flags

Additional information